Add the new VECTOR type #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbussink
commented
Jul 18, 2024
| @@ -926,6 +926,8 @@ int trilogy_build_stmt_execute_packet(trilogy_builder_t *builder, uint32_t stmt_ | |||
| case TRILOGY_TYPE_VAR_STRING: | |||
| case TRILOGY_TYPE_STRING: | |||
| case TRILOGY_TYPE_GEOMETRY: | |||
| case TRILOGY_TYPE_JSON: | |||
There was a problem hiding this comment.
This was missing JSON for some reason (probably bad copy paste), so I added it here for completeness.
MySQL 9.0 added a new vector type at the protocol level, so this adds support for it. It is a binary length encoded buffer, so treat it as such. Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
force-pushed
the
add-vector-type
branch
from
a6ceca4
to
0014c81
Compare
|
See also https://dev.mysql.com/doc/dev/mysql-server/latest/field__types_8h.html for the value here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL 9.0 added a new vector type at the protocol level, so this adds support for it. It is a binary length encoded buffer, so treat it as such.