Copy the in_transaction flag into Trilogy::Result
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag (SERVER_STATUS_IN_TRANS, position 0x0001) is part of the server_status bitfield sent with every OK_Packet which is already stored on the connection. But this particular data is not always safe to read from the connection since in some cases one or more queries may have been executed since the result was generated. So to increase safety let's also store it on the Result itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #17, added at @matthewd's suggestion.
The
SERVER_STATUS_IN_TRANSflag is part of the server_status bitfield sent with every OK_Packet which is already stored on the connection. But this particular data is not always safe to read from the connection since in some cases one or more queries may have been executed since the result was generated, invalidating the prior data. To increase safety let's also store it on the Result itself.