Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stenciljs to support react-19 #3189

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ElishaSamPeterPrabhu
Copy link
Collaborator

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu requested review from coliff and a team as code owners February 25, 2025 08:51
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu linked an issue Feb 25, 2025 that may be closed by this pull request
2 tasks
Copy link

netlify bot commented Feb 25, 2025

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/67c57fdcb7f41f06583ae632
😎 Deploy Preview https://deploy-preview-3189--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ElishaSamPeterPrabhu
Copy link
Collaborator Author

ElishaSamPeterPrabhu commented Feb 25, 2025

@Kavin-Trimble @jewel-shajan

From inside the ./stencil-workspace directory:

  1. Run npm install
  2. Run npm run build
  3. Run npm link

From inside the ./react-workspace/react-19 directory:

  1. Run npm install
  2. Run npm run build
  3. Run npm link

From inside the ./react-workspace/test-react-v19 directory:

  1. Run npm install
  2. Run npm link @trimble-oss/modus-web-components @trimble-oss/modus-react-components
  3. Run npm start

This comment has been minimized.

This comment has been minimized.

@coliff coliff force-pushed the 3184-support-for-react-19 branch from a025836 to 75fb8c0 Compare March 1, 2025 09:28

This comment has been minimized.

This comment has been minimized.

Copy link

Failed

  • 0.00% Coverage on New Code (is less than 80.00%)
  • 60.86% Duplicated Lines (%) on New Code (is greater than 3.00%)

Analysis Details

72 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 72 Code Smells

Coverage and Duplications

  • Coverage 0.00% Coverage (0.00% Estimated after merge)
  • Duplications 60.86% Duplicated Code (15.30% Estimated after merge)

Project ID: Modus.trimble:ModusWebComponents

View in SonarQube

@coliff
Copy link
Member

coliff commented Mar 3, 2025

I just tested this and got error from react-19 folder when running npm run build step:
image

@Kavin-Trimble
Copy link
Collaborator

The React 19 update has been tested and is functioning as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for React-19
3 participants