Skip to content

Commit

Permalink
Do not override heapHeadroomPerNode by default
Browse files Browse the repository at this point in the history
Trino sets the headroom to 30% of heap by default. Overriding it to 1GB
is error prone, as somebody may increase the heap size without adjusting
the headroom.
  • Loading branch information
arhimondr authored and losipiuk committed Jan 11, 2023
1 parent 95d2607 commit e919541
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions charts/trino/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,15 @@ The following table lists the configurable parameters of the Trino chart and the
| `coordinator.jvm.maxHeapSize` | | `"8G"` |
| `coordinator.jvm.gcMethod.type` | | `"UseG1GC"` |
| `coordinator.jvm.gcMethod.g1.heapRegionSize` | | `"32M"` |
| `coordinator.config.memory.heapHeadroomPerNode` | | `"1GB"` |
| `coordinator.config.memory.heapHeadroomPerNode` | | `""` |
| `coordinator.additionalJVMConfig` | | `{}` |
| `coordinator.resources` | | `{}` |
| `coordinator.livenessProbe` | | `{}` |
| `coordinator.readinessProbe` | | `{}` |
| `worker.jvm.maxHeapSize` | | `"8G"` |
| `worker.jvm.gcMethod.type` | | `"UseG1GC"` |
| `worker.jvm.gcMethod.g1.heapRegionSize` | | `"32M"` |
| `worker.config.memory.heapHeadroomPerNode` | | `"1GB"` |
| `worker.config.memory.heapHeadroomPerNode` | | `""` |
| `worker.additionalJVMConfig` | | `{}` |
| `worker.resources` | | `{}` |
| `worker.livenessProbe` | | `{}` |
Expand Down
4 changes: 2 additions & 2 deletions charts/trino/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ coordinator:

config:
memory:
heapHeadroomPerNode: "1GB"
heapHeadroomPerNode: ""

additionalJVMConfig: {}

Expand Down Expand Up @@ -201,7 +201,7 @@ worker:

config:
memory:
heapHeadroomPerNode: "1GB"
heapHeadroomPerNode: ""

additionalJVMConfig: {}

Expand Down

0 comments on commit e919541

Please sign in to comment.