Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory-aware autoscaling for worker nodes #219

Conversation

yardenc2003
Copy link
Contributor

Added support in autoscaling worker nodes according to memory utilization metric.

Copy link

cla-bot bot commented Sep 4, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@@ -20,6 +20,12 @@ spec:
target:
type: Utilization
averageUtilization: {{ .Values.server.autoscaling.targetCPUUtilizationPercentage }}
- type: Resource
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be wrapped in a conditional block, and .Values.server.autoscaling.targetCPUUtilizationPercentage not have a default? I'm wondering if memory based scaling always makes sense - is any Trino cluster able to utilize more memory, or it depends on the datasources, stats, data skew, etc.

@nineinchnick
Copy link
Member

Superseded by #239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants