Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cert and key kwargs parsing from URL in sqlachemy's create_connect_args function #478

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

a-narsudinov
Copy link
Contributor

Description

Previous version of code contained an always true condition that may lead to unintended behaviour. This bug was captured by flake8 linter, so it may be a good idea to include it as a part of CI process.

Non-technical explanation

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text:

* Fix `cert` and `key` kwargs parsing from URL in sqlachemy's `create_connect_args` function

Copy link

cla-bot bot commented Aug 16, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Aleksandr Narsudinov.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

This comment was marked as duplicate.

This comment was marked as duplicate.

@a-narsudinov
Copy link
Contributor Author

HI gyus! I've signed the CLA, but I guess something went wrong. What should I do next?

@hashhar
Copy link
Member

hashhar commented Aug 29, 2024

@cla-bot check

This comment was marked as duplicate.

This comment was marked as duplicate.

Previous version of code contained an always true condition that may
lead to unintended behaviour.
Copy link

cla-bot bot commented Aug 29, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty to add a test. Thanks for the fix.

I'll merge once CLA is processed. It gets processed manually every 2 weeks.

@hashhar
Copy link
Member

hashhar commented Sep 26, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Sep 26, 2024
Copy link

cla-bot bot commented Sep 26, 2024

The cla-bot has been summoned, and re-checked this pull request!

@hashhar hashhar merged commit f8c7a32 into trinodb:master Sep 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants