Refactor RunLengthEncodedBlock hash combination logic #19759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
reviewed
Nov 17, 2023
core/trino-main/src/main/java/io/trino/operator/scalar/CombineHashFunction.java
Outdated
Show resolved
Hide resolved
Comment on lines
+460
to
+467
| BytecodeExpression setHashExpression; | ||
| if (field.index() == 0) { | ||
| // hashes[index] = hash; | ||
| setHashExpression = hashes.setElement(index, hash); | ||
| } | ||
| else { | ||
| // hashes[index] = CombineHashFunction.getHash(hashes[index], hash); | ||
| setHashExpression = hashes.setElement(index, invokeStatic(CombineHashFunction.class, "getHash", long.class, hashes.getElement(index), hash)); |
There was a problem hiding this comment.
Previously, the same hash assignment expression was used in the RLE loop as well as the normal block loop, so it was declared above both of them (RLE loop was defined first). Now it's only used in the normal block loop, so I moved it closer to it's usage site.
pettyjamesm
force-pushed
the
simplify-rle-combine-hash
branch
from
b885a29 to
f9690fc
Compare
martint
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors
RunLengthEncodedBlockcolumn-wise hash calculations to call a common implementation of the hash combination loop instead of directly embedding the same loop logic in each method of generated code. This reduces overall code size and JIT warm-up time for RLE hash handling.Additional context and related issues
Follows up from #19723
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: