-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend syntax for Dynamic Catalogs #22188
base: master
Are you sure you want to change the base?
Conversation
@martint @dain @kokosing @nineinchnick @SemionPar please review |
@@ -155,6 +162,7 @@ statement | |||
| EXPLAIN ANALYZE VERBOSE? statement #explainAnalyze | |||
| SHOW CREATE TABLE qualifiedName #showCreateTable | |||
| SHOW CREATE SCHEMA qualifiedName #showCreateSchema | |||
| SHOW CREATE CATALOG identifier #showCreateCatalog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation exposes all properties even if it's marked as @ConfigHidden
or @ConfigSecuritySensitive
. I think we should hide or redact such properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed SHOW CREATE CATALOG
from this PR. It should be possible to re-add it once the following are merged:
- Add connector SPI for returning redactable properties #24562
- Redact sensitive information in catalog queries #24563
I'm not sure if we want to introduce CREATE CATALOG LIKE
(at least not at this stage). One question that comes to mind is how to define access rules for it. According to the SQL specification for CREATE TABLE LIKE
:
If a <like clause> is contained in a <table definition>, then the applicable privileges for A shall include
SELECT privilege on the table identified in the <like clause>.
The issue is that we don’t have a SELECT privilege for catalogs.
I’m also not aware of any databases that provide CREATE ... LIKE
functionality for anything other than tables. This makes it difficult to infer whether there’s a common approach we could adopt in this scenario.
core/trino-grammar/src/main/antlr4/io/trino/grammar/sql/SqlBase.g4
Outdated
Show resolved
Hide resolved
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
I am adding the stale-ignore label under the assumption that you are still driving this PR to completion @ssheikin |
Session session = stateMachine.getSession(); | ||
|
||
accessControl.checkCanRenameCatalog(session.toSecurityContext(), statement.getSource().getValue(), statement.getTarget().getValue()); | ||
|
||
catalogManager.renameCatalog(new CatalogName(statement.getSource().getValue()), new CatalogName(statement.getTarget().getValue())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you omit lowercase intentionally?
trino> CREATE CATALOG test USING memory;
CREATE CATALOG
trino> ALTER CATALOG test RENAME TO TEST;
RENAME CATALOG
trino> show catalogs;
Catalog
---------
TEST
memory
system
tpch
(4 rows)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was unintentional. I updated it to match how other catalog statements work.
- RENAME - SET PROPERTIES
Co-authored-by: Jan Waś <[email protected]>
ee4ebe3
to
93954a1
Compare
Co-authored-by: Jan Waś <[email protected]>
93954a1
to
315ed4d
Compare
Current status of this PR: it will no longer include |
I have updated the description |
Description
RENAME
,SET PROPERTIES
implementedcatalog owner
is not supported yet.catalog comment
is not supported yet.Additional context and related issues
Trino epic #12709
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: