Rewrite TestNG, JUnit Assertions to AssertJ #22305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssheikin
commented
Jun 6, 2024
client/trino-cli/src/test/java/io/trino/cli/lexer/TestStatementSplitter.java
Show resolved
Hide resolved
wendigo
approved these changes
Jun 6, 2024
core/trino-main/src/test/java/io/trino/operator/output/TestPositionsAppenderPageBuilder.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/operator/output/TestPositionsAppenderPageBuilder.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/operator/output/TestPositionsAppenderPageBuilder.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/operator/output/TestPositionsAppenderPageBuilder.java
Outdated
Show resolved
Hide resolved
core/trino-parser/src/test/java/io/trino/sql/parser/TestStatementBuilder.java
Outdated
Show resolved
Hide resolved
...ctions/src/test/java/io/trino/plugin/teradata/functions/dateformat/TestDateFormatParser.java
Outdated
Show resolved
Hide resolved
|
Beautiful. Thank you @ssheikin |
ssheikin
force-pushed
the
ssheikin/940/trino/migrate-assertions-junit->assertj
branch
from
2fc0711 to
1477c94
Compare
ssheikin
force-pushed
the
ssheikin/940/trino/migrate-assertions-junit->assertj
branch
3 times, most recently
from
3d65bad to
b3703bd
Compare
ssheikin
force-pushed
the
ssheikin/940/trino/migrate-assertions-junit->assertj
branch
2 times, most recently
from
7d4c3c2 to
9c2c2c3
Compare
|
Remove the "(automated)" / "(manual)" from the commit messages. |
|
@martint should I squash those commits then? |
|
Yes, not a bad idea, since they are multiple steps of the same logical change. |
ssheikin
force-pushed
the
ssheikin/940/trino/migrate-assertions-junit->assertj
branch
2 times, most recently
from
203b11d to
2d8a434
Compare
ssheikin
changed the title
ssheikin
force-pushed
the
ssheikin/940/trino/migrate-assertions-junit->assertj
branch
from
2d8a434 to
05e4b1f
Compare
Changed automatically by openrewrite recipe
```
<plugin>
<groupId>org.openrewrite.maven</groupId>
<artifactId>rewrite-maven-plugin</artifactId>
<version>5.32.0</version>
<configuration>
<activeRecipes>
<recipe>org.openrewrite.java.testing.assertj.JUnitToAssertj</recipe>
</activeRecipes>
</configuration>
<dependencies>
<dependency>
<groupId>org.openrewrite.recipe</groupId>
<artifactId>rewrite-testing-frameworks</artifactId>
<version>2.10.1</version>
</dependency>
</dependencies>
</plugin>
```
run
```
./mvnw rewrite:run -Dmaven.javadoc.skip=true -DskipTests=true -Dmaven.site.skip=true -Dmaven.artifact.threads=16 -T 1C -e -Dair.check.skip-all=true --no-snapshot-updates -pl '!:trino-product-tests,!:trino-product-tests-launcher,!:trino-server-rpm'
```
Some formatting was fixed manually for readability.
Then, rewrite remaining JUnit Assertions to AssertJ manually, because
some entries were not migrated by `./mvnw rewrite:run`.
Changed automatically by openrewrite recipe openrewrite/rewrite-testing-frameworks#520 ``` <plugin> <groupId>org.openrewrite.maven</groupId> <artifactId>rewrite-maven-plugin</artifactId> <version>5.32.0</version> <configuration> <activeRecipes> <recipe>org.openrewrite.java.testing.assertj.TestNgToAssertj</recipe> </activeRecipes> </configuration> <dependencies> <dependency> <groupId>org.openrewrite.recipe</groupId> <artifactId>rewrite-testing-frameworks</artifactId> <version>2.11.0-SNAPSHOT</version> </dependency> </dependencies> </plugin> ``` run ``` ./mvnw rewrite:run -Dmaven.javadoc.skip=true -DskipTests=true -Dmaven.site.skip=true -Dmaven.artifact.threads=16 -T 1C -e -Dair.check.skip-all=true --no-snapshot-updates -pl '!:trino-server-rpm' ``` Some formatting was fixed manually for readability. Then, rewrite remaining TestNG Assertions to AssertJ manually, because some entries were not migrated by `./mvnw rewrite:run`.
ssheikin
force-pushed
the
ssheikin/940/trino/migrate-assertions-junit->assertj
branch
from
05e4b1f to
779f21b
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed automatically by openrewrite recipe
org.openrewrite.java.testing.assertj.JUnitToAssertjand custom one
org.openrewrite.java.testing.assertj.TestNgToAssertjopenrewrite/rewrite-testing-frameworks#520
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.