Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Added Docs Update: Graceful shutdown request needs X-Trino-User head… #23000

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

datasundae
Copy link

Fix for Docs Update: Graceful shutdown request needs X-Trino-User header #22593
graceful-shutdown.html in docs

Description

Added Docs Update: Graceful shutdown request needs X-Trino-User header #22593 adding phrase -H X-Trino-User: authorizeduser to code

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({Docs Update: Graceful shutdown request needs X-Trino-User header}`22593`)

Copy link

cla-bot bot commented Aug 10, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added the docs label Aug 10, 2024
@mosabua
Copy link
Member

mosabua commented Aug 26, 2024

Oh ... you actually need to change the source code for the docs and commit that. Find more info in https://github.com/trinodb/trino/blob/master/docs/README.md

Specifically this file https://github.com/trinodb/trino/blob/master/docs/src/main/sphinx/admin/graceful-shutdown.md

Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants