Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SetDigest, BingTile, Kdb Tree types (de)serialization in client protocol #24612

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Jan 2, 2025

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## CLI/JDBC
* Fix deserialization of SetDigest, BingTile, Kdb Tree types({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Jan 2, 2025
@wendigo wendigo force-pushed the serafin/client-types branch from 2ba8c29 to b5528c5 Compare January 2, 2025 14:25
Copy link
Member

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I may not understand why some stuff was put and some not in StandardTypes. @electrum please speak up when you have a chance

@wendigo wendigo force-pushed the serafin/client-types branch from b5528c5 to 7fda4b0 Compare January 2, 2025 15:21
@wendigo wendigo changed the title Fix geometry type serde in the client protocol Fix SetDigest, BingTile, Kdb Tree types (de)serialization in client protocol Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants