Extend AbstractTestQueryFramework in TestRedshiftUnload #24614
Merged
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
approved these changes
Jan 2, 2025
|
/test-with-secrets sha=ca4c74e4bf05c977fe516b1d2c6f4d21d9bfa2bd |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/12594222392 |
|
Could you confirm CI failure? |
|
@ebyhr failure is not related to code changes. Can you please restart the job? |
|
@mayankvadariya Please investigate the cause. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AbstractTestQueries was extended to cover different Trino query shapes.
However, it may not be necessary as there are query shape duplicates in
AbstractTestQueries. Additionally, AbstractTestQueries doesn't cover
different query shapes.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.