Skip to content
This repository has been archived by the owner on Feb 26, 2023. It is now read-only.

Resync with latest production code #2

Merged

Conversation

ssoloff
Copy link
Member

@ssoloff ssoloff commented Nov 24, 2017

This PR is in preparation of changes that need to be made to debug triplea-game/triplea#2603.

Somehow the production code got out of sync with the version used to initialize this repository. This commit ensures the repo code is in sync with the latest production code while maintaining the changes previously applied to remove hard-coded sensitive information from the source code, as well as to allow MARTI to run from a Docker container.

If you view this PR with whitespace changes ignored (?w=1), you'll note that a large number of the differences are simply whitespace.

Somehow the production code got out of sync with the version used to
initialize this repository.  This commit ensures the repo code is in
sync with the latest production code while maintaining the changes
previously applied to remove hard-coded sensitive information from the
source code, as well as to allow MARTI to run from a Docker container.
Copy link
Member

@RoiEXLab RoiEXLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging now in order to speed up things.
Please redo some of the cleanup changes being reverted in this PR at a later time.
And remove the ^M character if you get there...

@@ -0,0 +1,3 @@
<FilesMatch "\.(key|dat)$">
deny from all
</FilesMatch>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this file is going to affect anything since we're using nginx and not apache.

@RoiEXLab RoiEXLab merged commit 46913c7 into triplea-game:master Nov 24, 2017
@ssoloff
Copy link
Member Author

ssoloff commented Nov 24, 2017

Please redo some of the cleanup changes being reverted in this PR at a later time.

Note that there were no cleanup changes submitted to this repo since I received the initial zipball back in April. This code is what is currently reflected in production. I assumed that the differences encompassed in this PR were made directly in production (or the zipball I received contained changes never deployed to production).

Regardless, I plan on submitting some cleanup PRs, but only after we have a process in place to deploy this version. 😄

@ssoloff ssoloff deleted the resync-with-latest-production-code branch November 25, 2017 04:35
@ssoloff ssoloff mentioned this pull request Dec 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants