This repository has been archived by the owner on Feb 26, 2023. It is now read-only.
Fix IPv6 registration error #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ip2long() function cannot parse an IPv6 address. Thus, when a user registers using a public IPv6 address, the IP variable contains the value FALSE instead of an integer representing the IP address. This prevents the record from being inserted into the pending_validations table. However, due to improper error handling, the user still receives an email asking them to confirm their email address. Any attempt to verify the email address fails due to no corresponding record being present in the pending_validations table. It was observed that we don't actually use the the IP address recorded in the pending_validations table. Therefore, the temporary fix employed in this commit is to simply set the IP address to zero for all registrations. A future change will remove this column from the database entirely.
RoiEXLab
approved these changes
Jan 4, 2018
|
@RoiEXLab Yes, I'll eventually get around to removing the IP address column from the database schema. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes triplea-game/triplea#2603.
The
ip2long()function cannot parse an IPv6 address. Thus, when a user registers using a public IPv6 address, the IP variable contains the valueFALSEinstead of an integer representing the IP address. This prevents the record from being inserted into thepending_validationstable. However, due to improper error handling, the user still receives an email asking them to confirm their email address. Any attempt to verify the email address fails due to no corresponding record being present in thepending_validationstable.It was observed that we don't actually use the the IP address recorded in the
pending_validationstable. Therefore, the temporary fix employed in this commit is to simply set the IP address to zero for all registrations. A future change will remove this column from the database entirely.