probably hopeless attempt to fix leaking library loaders

scala/scala-impl/test/org/jetbrains/plugins/scala/base/ScalaLightPlatformCodeInsightTestCaseAdapter.java

@@ -24,11 +24,12 @@
 import org.jetbrains.plugins.scala.debugger.Scala_2_10$;
 import org.jetbrains.plugins.scala.util.TestUtils;
 import scala.collection.Seq;
+import scala.collection.immutable.Vector$;
+import scala.collection.mutable.Buffer;
+import scala.collection.mutable.Buffer$;
 
 import java.io.IOException;
 import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.List;
 
 /**
  * @author Alexander Podkhalyuzin
@@ -71,21 +72,21 @@ public Module module() {
 
     @Override
     public Seq<LibraryLoader> librariesLoaders() {
-        return scala.collection.JavaConverters.asScalaBuffer(librariesLoadersAdapter());
-    }
-
-    private List<LibraryLoader> librariesLoadersAdapter() {
         Module module = module();
+        ArrayList<LibraryLoader> back = new ArrayList<>();
 
-        ArrayList<LibraryLoader> result = new ArrayList<LibraryLoader>();
-        result.add(new ScalaLibraryLoader(isIncludeReflectLibrary(), module));
+        ScalaLibraryLoader scalaLoader = new ScalaLibraryLoader(isIncludeReflectLibrary(), module);
+        back.add(scalaLoader);
 
         String path = rootPath();
         if (path != null) {
-            result.add(new SourcesLoader(path, module));
+            back.add(new SourcesLoader(path, module));
         }
 
-        result.addAll(Arrays.asList(additionalLibraries()));
+        Buffer<LibraryLoader> result = scala.collection.JavaConverters.asScalaBuffer(back);
+        Seq addLibs = additionalLibraries();
+        //noinspection unchecked (because variance)
+        result.$plus$plus$eq(addLibs);
 
         return result;
     }
@@ -120,8 +121,8 @@ protected boolean isIncludeReflectLibrary() {
         return false;
     }
 
-    protected ThirdPartyLibraryLoader[] additionalLibraries() {
-        return EMPTY_LOADERS_ARRAY;
+    protected Seq<ThirdPartyLibraryLoader> additionalLibraries() {
+        return Vector$.MODULE$.empty();
     }
 
     protected VirtualFile getVFileAdapter() {

scala/scala-impl/test/org/jetbrains/plugins/scala/failed/resolve/Postgres.scala

@@ -12,8 +12,8 @@ import org.junit.experimental.categories.Category
 @Category(Array(classOf[PerfCycleTests]))
 class Postgres extends FailedResolveTest("postgresql") {
 
-  override protected def additionalLibraries(): Array[ThirdPartyLibraryLoader] =
-    Array(PostgresLoader()(module))
+  override protected def additionalLibraries(): Seq[ThirdPartyLibraryLoader] =
+    Seq(PostgresLoader()(module))
 
   def testSCL8556(): Unit = doTest()
 }

scala/scala-impl/test/org/jetbrains/plugins/scala/failed/resolve/ScalazTest.scala

@@ -11,8 +11,8 @@ import org.junit.experimental.categories.Category
 @Category(Array(classOf[PerfCycleTests]))
 class ScalazTest extends FailedResolveTest("scalaz") {
 
-  override protected def additionalLibraries(): Array[ThirdPartyLibraryLoader] =
-    Array(ScalaZCoreLoader()(module))
+  override protected def additionalLibraries(): Seq[ThirdPartyLibraryLoader] =
+    Seq(ScalaZCoreLoader()(module))
 
   def testSCL7213(): Unit = doTest()
 

scala/scala-impl/test/org/jetbrains/plugins/scala/failed/typeInference/ScalaZTest.scala

@@ -12,8 +12,8 @@ import org.junit.experimental.categories.Category
 @Category(Array(classOf[PerfCycleTests]))
 class ScalaZTest extends TypeInferenceTestBase {
 
-  override protected def additionalLibraries(): Array[ThirdPartyLibraryLoader] =
-    Array(ScalaZCoreLoader()(module))
+  override protected def additionalLibraries(): Seq[ThirdPartyLibraryLoader] =
+    Seq(ScalaZCoreLoader()(module))
 
   def testSCL5706(): Unit = {
     doTest(

scala/scala-impl/test/org/jetbrains/plugins/scala/failed/typeInference/Specs2ToScalaCheckImplicitTest.scala

@@ -11,8 +11,8 @@ import org.junit.experimental.categories.Category
 @Category(Array(classOf[PerfCycleTests]))
 class Specs2ToScalaCheckImplicitTest extends TypeInferenceTestBase {
 
-  override protected def additionalLibraries(): Array[ThirdPartyLibraryLoader] =
-    Array(Specs2Loader("2.4.15")(module), ScalaZCoreLoader()(module))
+  override protected def additionalLibraries(): Seq[ThirdPartyLibraryLoader] =
+    Seq(Specs2Loader("2.4.15")(module), ScalaZCoreLoader()(module))
 
   def testSCL8864(): Unit = doTest {
     s"""object Main extends App {

scala/scala-impl/test/org/jetbrains/plugins/scala/lang/adjustTypes/tests/AdjustTypesTests.scala

@@ -43,8 +43,8 @@ class AdjustTypesTests extends AdjustTypesTestBase {
 
 class AdjustCatsTypeTest extends AdjustTypesTestBase {
 
-  override protected def additionalLibraries(): Array[ThirdPartyLibraryLoader] =
-    Array(CatsLoader()(module))
+  override protected def additionalLibraries(): Seq[CatsLoader] =
+    Seq(CatsLoader()(module))
 
   def testSCL10006(): Unit = doTest()
 }

scala/scala-impl/test/org/jetbrains/plugins/scala/lang/macros/MonocleLensesTest.scala

@@ -19,11 +19,11 @@ class MonocleLensesTest extends ScalaLightPlatformCodeInsightTestCaseAdapter {
 
   override implicit val version: ScalaVersion = Scala_2_12
 
-  override protected def additionalLibraries(): Array[ThirdPartyLibraryLoader] = {
+  override protected def additionalLibraries(): Seq[ThirdPartyLibraryLoader] = {
     import MonocleLensesTest._
 
     implicit val module: Module = getModuleAdapter
-    Array(MonocleCoreLoader(), MonocleMacroLoader(), MonocleGeneric())
+    Seq(MonocleCoreLoader(), MonocleMacroLoader(), MonocleGeneric())
   }
 
   protected def folderPath: String = TestUtils.getTestDataPath

scala/scala-impl/test/org/jetbrains/plugins/scala/lang/typeInference/generated/TypeInferenceCatsTest.scala

@@ -11,8 +11,8 @@ import org.junit.experimental.categories.Category
 @Category(Array(classOf[SlowTests]))
 class TypeInferenceCatsTest extends TypeInferenceTestBase {
 
-  override protected def additionalLibraries(): Array[ThirdPartyLibraryLoader] =
-    Array(CatsLoader()(module))
+  override protected def additionalLibraries(): Seq[ThirdPartyLibraryLoader] =
+    Seq(CatsLoader()(module))
 
   override protected def folderPath: String = super.folderPath + "cats/"
 

scala/scala-impl/test/org/jetbrains/plugins/scala/lang/typeInference/generated/TypeInferenceScalazTest.scala

@@ -14,8 +14,8 @@ class TypeInferenceScalazTest extends TypeInferenceTestBase {
   //This class was generated by build script, please don't change this
   override def folderPath: String = super.folderPath + "scalaz/"
 
-  override protected def additionalLibraries(): Array[ThirdPartyLibraryLoader] =
-    Array(ScalaZCoreLoader()(module))
+  override protected def additionalLibraries(): Seq[ThirdPartyLibraryLoader] =
+    Seq(ScalaZCoreLoader()(module))
 
   def testSCL3819() {
     doTest()

scala/scala-impl/test/org/jetbrains/plugins/scala/lang/typeInference/generated/TypeInferenceSlickTest.scala

@@ -14,8 +14,8 @@ class TypeInferenceSlickTest extends TypeInferenceTestBase {
   //This class was generated by build script, please don't change this
   override def folderPath: String = super.folderPath + "slick/"
 
-  override protected def additionalLibraries(): Array[ThirdPartyLibraryLoader] =
-    Array(SlickLoader()(module))
+  override protected def additionalLibraries(): Seq[ThirdPartyLibraryLoader] =
+    Seq(SlickLoader()(module))
 
   def testSCL9261(): Unit = doTest()
 

scala/scala-impl/test/org/jetbrains/plugins/scala/lang/typeInference/generated/TypeInferenceSprayTest.scala

@@ -13,8 +13,8 @@ class TypeInferenceSprayTest extends TypeInferenceTestBase {
   //This class was generated by build script, please don't change this
   override def folderPath: String = super.folderPath + "spray/"
 
-  override protected def additionalLibraries(): Array[ThirdPartyLibraryLoader] =
-    Array(SprayLoader()(module))
+  override protected def additionalLibraries(): Seq[ThirdPartyLibraryLoader] =
+    Seq(SprayLoader()(module))
 
   def testSCL8274(): Unit = doTest()
 }

scala/scala-impl/test/scala/meta/ScalaMetaLibrariesOwner.scala

@@ -10,7 +10,7 @@ trait ScalaMetaLibrariesOwner extends ScalaSdkOwner {
 
   import ScalaMetaLibrariesOwner._
 
-  protected def additionalLibraries(): Array[ThirdPartyLibraryLoader] = Array(
+  protected def additionalLibraries(): Seq[ThirdPartyLibraryLoader] = Seq(
     MetaCommonLoader(),
     MetaDialectsLoader(),
     MetaInlineLoader(),

scala/scala-impl/test/scala/meta/quasiquotes/QuasiQuoteTypeInferenceTestBase.scala

@@ -7,8 +7,8 @@ import scala.meta.ScalaMetaLibrariesOwner
 
 abstract class QuasiQuoteTypeInferenceTestBase extends TypeInferenceTestBase with ScalaMetaLibrariesOwner {
 
-  override protected def additionalLibraries(): Array[ThirdPartyLibraryLoader] =
-    super.additionalLibraries()
+  override protected def additionalLibraries(): Seq[ThirdPartyLibraryLoader] =
+    super[ScalaMetaLibrariesOwner].additionalLibraries()
 
   override protected def doTest(fileText: String): Unit =
     super.doTest(