Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo for visualize #141

Draft
wants to merge 13 commits into
base: analyze_subcommand_phase1
Choose a base branch
from
Draft

Conversation

nv-braf
Copy link
Contributor

@nv-braf nv-braf commented Oct 17, 2024

No description provided.

nv-braf and others added 13 commits October 1, 2024 18:13
* Initial code done. Some unit testing in place

* All unit tests passing + pre-commit changes

* Fixing codeQL issue

* Fixing pytest issue

* Adding TypeAlias

* Removing python 3.8

* Changes based on pre-review w/ Elias

* Fixing codeQL issue

* Removing type ignore

* Fixing comment
* Adding Records and MCM. Very basic unit tests passing.

* Fixes + all unit testing completed

* Adding missing record testing + missing record file
* Initial changes, basic unit tests passing

* Adding support for making the objective a telemetry metric

* Calculation logic + unit testing added

* Constraint logic in place. All unit tests passing

* Fix codeQL issues.

* Removing accidental negation
* Created type top-level file

* Added logic and testing for search space methods

* Added logic and unit testing for generating objectives

* Fixing codeQL issues

* Adding early termination logic

* Fixing logger and adding debug methods

* Adding end-to-end generator testing
* Creating sweep based objective generator

* Refactoring and cleaning up type aliases

* Fixing codeQL issues

* Fixing generator count test

* Changing get_list to assert versus return an empty list
* Initialization of class complete

* Refactoring set options method

* Added CLI string method

* Adding representation method

* Fixing codeQL issues

* Changing asserts to use ValueError

* Removing comment

* Fixes based on CR

* Removing try-except
* Differentiating btw PA and GAP runtime parameters

* Adding GAP options to config command

* Adding GAP option to optimize

* Adding logic for anaylze to search parameters

* Fixing codeQL issues

* Creating enum for subcommand
* Adding GAP option to optimize

* Fixing codeQL issues

* Adding config for genai-perf

* Fixing codeQL issues
* Adding GAP option to optimize

* Fixing codeQL issues

* Adding RunConfig class along w/ missing checkpoint support to config classes
* Adding GAP option to optimize

* Fixing codeQL issues

* Results class initial coding w/ testing

* Minor refactor

* Fixing issue in RCM testing

* Fixing codeQL issues
* initial changes

* Adding GAP option to optimize

* Fixing codeQL issues

* Results class initial coding w/ testing

* Fixing issue in RCM testing

* Fixing codeQL issues

* Checkpoint class creation

* Fixing codeQL issues

* fixing codeql issue

* Removing checkpoint file

* Removing checkpoint file

* Fixing json to properly format checkpoint file

* Minor typing cleanup

* Adding records for ISL/OSL and testing this in checkpoint creation

* Changing method name

* Changing read/write checkpoint method names
from genai_perf.record.types.input_sequence_length import InputSequenceLength
from genai_perf.record.types.perf_latency_p99 import PerfLatencyP99
from genai_perf.record.types.perf_throughput import PerfThroughput
from genai_perf.types import ModelSearchParameters

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'ModelSearchParameters' is not used.


if __name__ == "__main__":
sys.exit(main())

Check warning

Code scanning / CodeQL

Use of the return value of a procedure Warning

The result of
main
is used even though it is always None.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant