Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISL/OSL CLI arg aliases #164

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Add ISL/OSL CLI arg aliases #164

merged 1 commit into from
Nov 4, 2024

Conversation

dyastremsky
Copy link
Contributor

Input sequence length (ISL) and output sequence length (OSL) are becoming very common paths for users, so add them as aliases to shorten the args --synthetic-input-tokens-mean and --output-tokens-mean.

We plan to simplify the CLI args when GenAI-Perf goes GA. We may also switch to config files. For now, this will aid usability for users who prefer using these aliases.

@lkomali
Copy link
Contributor

lkomali commented Nov 4, 2024

LGTM

@dyastremsky dyastremsky merged commit bee658a into main Nov 4, 2024
6 of 7 checks passed
@dyastremsky dyastremsky deleted the dyas-aliases branch November 4, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants