Adds support for skipping profiling if the Result is found in the checkpoint #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nv-braf
force-pushed
the
analyze_subcommand_phase1
branch
from
2a9e864
to
6ea90c9
Compare
|
Why does this PR contain changes made from previous PRs? |
nv-braf
force-pushed
the
add_support_for_checkpoint_config_matching
branch
from
82a604f
to
45b9811
Compare
Sorry about that! Every Monday I pull and rebase the dev branch (analyze_subcommand_phase1) from main to ensure that there will be minimal conflicts when we eventually merge. Unfortunately, this means I need to also rebase any branches I have up for review (which I sometimes forget to do!) |
nv-hwoo
reviewed
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the code to allow us to skip profiling a configuration that we have checkpointed (in a previous run).
Add in the missing method to create a representation of the GAP config and then it is the combination of GAP + PA representations that are used to determine if a config was already profiled.
If so, we skip, else we create a new/unique configuration name (by incrementing the number suffix of the highest currently stored configuration in the Results).