-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skeleton codes for dynamic grpc client support #213
Draft
nv-hwoo
wants to merge
8
commits into
maxine-poc
Choose a base branch
from
hwoo-maxine-barebone-client
base: maxine-poc
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a2c666c
add cmake for building dynamic grpc
nv-hwoo a8a73e6
add client backend skeleton code for dynamic grpc
nv-hwoo 35a5043
initialize skeleton instances
nv-hwoo 7cfc3bc
fix names
nv-hwoo 1ea789c
add skeleton for model parser
nv-hwoo 46637ab
fix minor bug
nv-hwoo 8efddcd
comment out not (yet) implemented member
nv-hwoo d90aeda
fix build failure
nv-hwoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
# Copyright 2020-2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
# | ||
# Redistribution and use in source and binary forms, with or without | ||
# modification, are permitted provided that the following conditions | ||
# are met: | ||
# * Redistributions of source code must retain the above copyright | ||
# notice, this list of conditions and the following disclaimer. | ||
# * Redistributions in binary form must reproduce the above copyright | ||
# notice, this list of conditions and the following disclaimer in the | ||
# documentation and/or other materials provided with the distribution. | ||
# * Neither the name of NVIDIA CORPORATION nor the names of its | ||
# contributors may be used to endorse or promote products derived | ||
# from this software without specific prior written permission. | ||
# | ||
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS ``AS IS'' AND ANY | ||
# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR | ||
# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR | ||
# CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, | ||
# EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, | ||
# PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR | ||
# PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY | ||
# OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
|
||
cmake_minimum_required (VERSION 3.18) | ||
|
||
set( | ||
DGRPC_CLIENT_BACKEND_SRCS | ||
dynamic_grpc_client.cc | ||
dynamic_grpc_client_backend.cc | ||
dynamic_grpc_infer_input.cc | ||
) | ||
|
||
set( | ||
DGRPC_CLIENT_BACKEND_HDRS | ||
dynamic_grpc_client.h | ||
dynamic_grpc_client_backend.h | ||
dynamic_grpc_infer_input.h | ||
) | ||
|
||
add_library( | ||
dgrpc-client-backend-library EXCLUDE_FROM_ALL OBJECT | ||
${DGRPC_CLIENT_BACKEND_SRCS} | ||
${DGRPC_CLIENT_BACKEND_HDRS} | ||
) | ||
|
||
# Include header files installed by CC client | ||
target_include_directories( | ||
dgrpc-client-backend-library | ||
PRIVATE | ||
${CMAKE_INSTALL_PREFIX}/include | ||
) | ||
|
||
target_link_libraries( | ||
dgrpc-client-backend-library | ||
) | ||
Comment on lines
+56
to
+58
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This isn't necessary since you're not listing any libraries: https://cmake.org/cmake/help/latest/command/target_link_libraries.html#overview |
||
|
||
if(${TRITON_ENABLE_GPU}) | ||
target_include_directories(dgrpc-client-backend-library | ||
PUBLIC ${CUDAToolkit_INCLUDE_DIRS}) | ||
|
||
# Need to enable this compilation flag, otherwise, ipc.h | ||
# will select mock-struct as opposed to the correct cuda | ||
# runtime header file. | ||
target_compile_definitions( | ||
dgrpc-client-backend-library | ||
PUBLIC TRITON_ENABLE_GPU=1 | ||
) | ||
endif() # TRITON_ENABLE_GPU |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,121 @@ | ||
// Copyright 2020-2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
// | ||
// Redistribution and use in source and binary forms, with or without | ||
// modification, are permitted provided that the following conditions | ||
// are met: | ||
// * Redistributions of source code must retain the above copyright | ||
// notice, this list of conditions and the following disclaimer. | ||
// * Redistributions in binary form must reproduce the above copyright | ||
// notice, this list of conditions and the following disclaimer in the | ||
// documentation and/or other materials provided with the distribution. | ||
// * Neither the name of NVIDIA CORPORATION nor the names of its | ||
// contributors may be used to endorse or promote products derived | ||
// from this software without specific prior written permission. | ||
// | ||
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS ``AS IS'' AND ANY | ||
// EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR | ||
// PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR | ||
// CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, | ||
// EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, | ||
// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR | ||
// PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY | ||
// OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
|
||
#include "dynamic_grpc_client.h" | ||
|
||
#include <chrono> | ||
#include <cstdint> | ||
#include <string> | ||
|
||
namespace triton::perfanalyzer::clientbackend::dynamicgrpc { | ||
|
||
Error | ||
DynamicGrpcInferResult::RequestStatus() const | ||
{ | ||
// TODO: Not required for synchronous streaming? | ||
return Error("Not implemented yet."); | ||
} | ||
|
||
Error | ||
DynamicGrpcInferResult::Id(std::string* id) const | ||
{ | ||
// TODO: Not required for synchronous streaming? | ||
return Error("Not implemented yet."); | ||
} | ||
|
||
Error | ||
DynamicGrpcInferResult::RawData( | ||
const std::string& output_name, std::vector<uint8_t>& buf) const | ||
{ | ||
// TODO | ||
return Error("Not implemented yet."); | ||
} | ||
|
||
//============================================================================== | ||
// | ||
DynamicGrpcClient::DynamicGrpcClient( | ||
const std::string& url, bool verbose, bool use_ssl, | ||
const SslOptions& ssl_options) | ||
: verbose_(verbose) | ||
{ | ||
// TODO | ||
std::cerr << "Not implemented yet." << std::endl; | ||
throw PerfAnalyzerException(GENERIC_ERROR); | ||
} | ||
|
||
DynamicGrpcClient::~DynamicGrpcClient() | ||
{ | ||
// TODO | ||
std::cerr << "Not implemented yet." << std::endl; | ||
throw PerfAnalyzerException(GENERIC_ERROR); | ||
} | ||
|
||
Error | ||
DynamicGrpcClient::BidiStreamRPC( | ||
InferResult** result, const InferOptions& options, | ||
const std::vector<InferInput*>& inputs, | ||
const std::vector<const InferRequestedOutput*>& outputs, | ||
const Headers& headers, grpc_compression_algorithm compression_algorithm) | ||
{ | ||
// TODO | ||
return Error("Not implemented yet."); | ||
} | ||
|
||
Error | ||
DynamicGrpcClient::StartStream( | ||
OnCompleteFn callback, bool enable_stats, uint32_t stream_timeout, | ||
const Headers& headers, grpc_compression_algorithm compression_algorithm) | ||
{ | ||
// TODO | ||
return Error("Not implemented yet."); | ||
} | ||
|
||
Error | ||
DynamicGrpcClient::StopStream() | ||
{ | ||
// TODO | ||
return Error("Not implemented yet."); | ||
} | ||
|
||
Error | ||
DynamicGrpcClient::PreRunProcessing( | ||
const InferOptions& options, const std::vector<InferInput*>& inputs, | ||
const std::vector<const InferRequestedOutput*>& outputs) | ||
{ | ||
// TODO | ||
return Error("Not implemented yet."); | ||
} | ||
|
||
Error | ||
DynamicGrpcClient::UpdateInferStat(const tc::RequestTimers& timer) | ||
{ | ||
// TODO | ||
return Error("Not implemented yet."); | ||
} | ||
|
||
//============================================================================== | ||
|
||
} // namespace triton::perfanalyzer::clientbackend::dynamicgrpc |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.