Starting to work on coroutines. #243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasnoble
force-pushed
the
add-coroutines
branch
from
073ace5 to
9cfc326
Compare
nicolasnoble
force-pushed
the
add-coroutines
branch
from
9cfc326 to
bd3ac04
Compare
nicolasnoble
force-pushed
the
add-coroutines
branch
from
bfc157e to
b59752b
Compare
…erf_analyzer into add-coroutines
| std::coroutine_handle<>::from_address(awaitingCoroutine).resume(); | ||
| } | ||
| } | ||
| [[no_unique_address]] std::monostate value_{}; |
There was a problem hiding this comment.
Is this necessary for this?:
In other words if the structs didn't have the same list of data member identifiers, the typedef line wouldn't work?
There was a problem hiding this comment.
It's for the await_resume at the end, and the various other generic places where we haul the result of the promise.
| @@ -0,0 +1,136 @@ | |||
| // Copyright 2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | |||
There was a problem hiding this comment.
nit: rename test_coroutine.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a Coroutine class in the pa namespace, which we will then be able to use for a lightweight scheduler.