fix: Add input validation to model load #404
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
mattwittwer
changed the title
mattwittwer
changed the title
yinggeh
reviewed
Jul 18, 2025
src/pb_utils.cc
Outdated
| bool | ||
| IsValidIdentifier(const std::string& input) | ||
| { | ||
| if (input.empty()) { |
There was a problem hiding this comment.
Updated is statements to simplify into one
| // other than 1, it can indicate a permission issue as a result of | ||
| // downloading the stub process from a cloud object storage service. | ||
| if (WEXITSTATUS(stub_status_code) != 1) { | ||
| if (!IsExecutableFile(python_backend_stub)) { |
There was a problem hiding this comment.
Out of curiosity, what's python_backend_stub file name?
There was a problem hiding this comment.
In the default container build this resolves to: /opt/tritonserver/backends/python/triton_python_backend_stub
but this can change based on the python_lib_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Simplify the model load command by invoking the python backend stub without shell interpretation. Additionally add checks for invalid characters in provided model names
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Tests for these changes have been added here: triton-inference-server/server#8276
Where should the reviewer start?
The majority of the changes are in the src/stub_launcher.cc
Review the updated flow for building the model load command.
Test plan:
Added testing to: triton-inference-server/server#8276
31707450
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)