Skip to content

fix crash during torch model reload with inter op thread parameter set #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix crash during torch model reload with inter op thread parameter set #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/libtorch.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,15 +532,17 @@ ModelState::ParseParameters()
TRITONSERVER_ErrorDelete(err);
}
} else {
if (inter_op_thread_count > 0) {
if ((inter_op_thread_count > 0) &&
(inter_op_thread_count != at::get_num_interop_threads()) &&
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can still allow a repeated call if two model config files set the number of interop threads to different values. (See #159 for a safer solution.)

(at::get_num_interop_threads() == std::thread::hardware_concurrency())) {
at::set_num_interop_threads(inter_op_thread_count);
LOG_MESSAGE(
TRITONSERVER_LOG_INFO,
(std::string("Inter op thread count is set to ") +
std::to_string(inter_op_thread_count) + " for model instance '" +
Name() + "'")
.c_str());
}
LOG_MESSAGE(
TRITONSERVER_LOG_INFO,
(std::string("Inter op thread count is set to ") +
std::to_string(at::get_num_interop_threads()) + " for model instance '" +
Name() + "'")
.c_str());
}
}

Expand Down