Enable armv8 CI #195
Merged
Enable armv8 CI #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digantdesai
force-pushed
the
test_armv8_ci
branch
21 times, most recently
from
a96b925 to
00f231b
Compare
This does not exist for Darwin + Arm64. TODO: Enable this selectively when possible.
digantdesai
force-pushed
the
test_armv8_ci
branch
from
00f231b to
4788f4c
Compare
digantdesai
force-pushed
the
test_armv8_ci
branch
6 times, most recently
from
bba2bfe to
d59e8a9
Compare
minjang
approved these changes
Dec 20, 2024
| @@ -757,7 +757,7 @@ def get_git_commit_hash(length=8): | |||
| "pytest-forked", | |||
| "pytest-xdist", | |||
| "scipy>=1.7.1", | |||
| "llnl-hatchet", | |||
| # "llnl-hatchet", # TODO: Re-enable this, not available on macos-arm64 | |||
There was a problem hiding this comment.
Will it be okay in other platforms? It's okay as you marked as TODO:
There was a problem hiding this comment.
It is mainly used in the proton profiler. I guess we can commit it with a TODO, and revisit this later.
|
Ah still failing, let me fix it. |
digantdesai
force-pushed
the
test_armv8_ci
branch
from
d59e8a9 to
e2aa74a
Compare
- Re-enable llnl-hatchet pip package installation - look into faster triton install - enable bf16 tests - enable openmp
digantdesai
force-pushed
the
test_armv8_ci
branch
from
e2aa74a to
e68c415
Compare
int3
reviewed
Dec 26, 2024
| @@ -12,6 +12,7 @@ | |||
| from triton.backends.driver import DriverBase | |||
| from triton.backends.compiler import GPUTarget | |||
|
|
|||
| from pathlib import Path | |||
There was a problem hiding this comment.
hm is this import getting used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.