-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dummy nvidia headers for offline builds #203
Conversation
Like the previous PR, this needs to go to the upstream. You are updating the nvidia backend. |
Opened triton-lang#5492 upstream. But in this specific circumstance, I doubt there will ever be a merge conflict as (1) these files are not actual Triton source code, but intended to be replaced by the downloaded cuda libraries by Lines 59 to 61 in daa7eb0
|
Once your PR is merged in the upstream, after our periodic rebasing, we will eventually get this PR. You don't need to make duplicate PRs. So, let me close it as this PR doesn't seem like an urgent fix. |
Understood, thanks for your patience! |
<!--- The core Triton is a small number of people, and we receive many PRs (thank you!). To help us review your code more quickly, **if you are a new contributor (less than 3 PRs merged) we ask that you complete the following tasks and include the filled-out checklist in your PR description.** Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. --> #4085 now makes it impossible to build Triton without downloading cuda libraries (see #5449). This PR remove dependencies to cuda headers, making it possible to build a functional Triton without downloading cuda for backends that don't require cuda at runtime (e.g. amd, cpu). Fixes #5449. See also triton-lang#202, triton-lang#203. # New contributor declaration - [x] I am not making a trivial change, such as fixing a typo in a comment. - [x] I have written a PR description following these [rules](https://cbea.ms/git-commit/#why-not-how). - [x] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`. - Select one of the following. - [ ] I have added tests. - `/test` for `lit` tests - `/unittest` for C++ tests - `/python/test` for end-to-end tests - [x] This PR does not need a test because build system change. - Select one of the following. - [x] I have not added any `lit` tests. - [ ] The `lit` tests I have added follow these [best practices](https://mlir.llvm.org/getting_started/TestingGuide/#filecheck-best-practices), including the "tests should be minimal" section. (Usually running Python code and using the instructions it generates is not minimal.)
Fixes #202. Based on my read of
download_and_copy
, specifically the usage ofshutil.copytree
andshutil.copy
, this should be safely replaced by the actual nvidia headers once they are downloaded, but I have not actually tested this.triton-cpu/python/setup.py
Lines 297 to 330 in daa7eb0
triton-cpu/python/setup.py
Lines 327 to 330 in daa7eb0
shutil.copytree
shutil.copy
Opening here instead of triton upstream because it's most relevant to the cpu backend and there probably won't be any merge conflicts (as
third_party/nvidia/backend/include
is ignored upstream).cc @pawelszczerbuk
New contributor declaration
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD
.Select one of the following.
/test
forlit
tests/unittest
for C++ tests/python/test
for end-to-end testsSelect one of the following.
lit
tests.lit
tests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)