Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default target selection logic #212

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Update default target selection logic #212

merged 1 commit into from
Jan 24, 2025

Conversation

digantdesai
Copy link
Collaborator

First try to lookup the Target in the given module. If it doesn't work, use the default target. And set it in the module.

Rationale: Issue #207

@digantdesai
Update default target selection logic
e1e9d73 
First try to lookup the Target in the given module.
If it doesn't work, use the default target. And set it in the module.

Rationale: Issue #207
@digantdesai digantdesai requested a review from ptillet as a code owner January 24, 2025 04:53
@digantdesai digantdesai requested a review from minjang January 24, 2025 04:53
@digantdesai digantdesai mentioned this pull request Jan 24, 2025
Closed
minjang
minjang approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@minjang minjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@minjang minjang merged commit 8b4787d into main Jan 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minjang minjang minjang approved these changes

@ptillet ptillet Awaiting requested review from ptillet ptillet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@digantdesai @minjang