Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC][BACKEND] Remove dead code in Nvidia backend's ConvertLayoutOpConversion #4523

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[NFC][BACKEND] Remove dead code in Nvidia backend's ConvertLayoutOpConversion #4523

wants to merge 4 commits into from
+14 −455

Conversation

Jokeren
Copy link
Contributor

@Jokeren Jokeren commented Aug 15, 2024 •
edited
Loading

No description provided.

ThomasRaoux
ThomasRaoux reviewed Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@ThomasRaoux ThomasRaoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not really NFC :)

Also it would be good to explicitly mention that this deprecate V100 and update the readme to bump the minimum supported version to sm_80

@Jokeren
Copy link
Contributor Author

Jokeren commented Aug 17, 2024

@ThomasRaoux I won't merge this PR in the short term, no worries. There are some remaining stuff I need to solve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasRaoux ThomasRaoux ThomasRaoux left review comments

@jlebar jlebar jlebar approved these changes

@ptillet ptillet Awaiting requested review from ptillet ptillet will be requested when the pull request is marked ready for review ptillet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jokeren @jlebar @ThomasRaoux