Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMD] Fix and enable upcasting fp8e4m3nv to fp16 #5604

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

knwng
Copy link
Contributor

@knwng knwng commented Jan 14, 2025

This commit fixed and enabled fp8e4m3nv to fp16 upcasting.
In order to properly handle denorms with LUT, this operation is no longer vectorized.

New contributor declaration

  • I am not making a trivial change, such as fixing a typo in a comment.

  • I have written a PR description following these
    rules.

  • I have run pre-commit run --from-ref origin/main --to-ref HEAD.

  • Select one of the following.

    • I have added tests.
      • /test for lit tests
      • /unittest for C++ tests
      • /python/test for end-to-end tests
    • This PR does not need a test because FILL THIS IN.
  • Select one of the following.

    • I have not added any lit tests.
    • The lit tests I have added follow these best practices,
      including the "tests should be minimal" section. (Usually running Python code
      and using the instructions it generates is not minimal.)

This commit fixed and enabled fp8e4m3nv to fp16 upcasting. In order to
properly handle denorms with LUT, this operation is no longer vectorized.
@antiagainst antiagainst marked this pull request as ready for review January 14, 2025 19:35
Copy link
Collaborator

@antiagainst antiagainst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antiagainst antiagainst merged commit aa833c9 into triton-lang:main Jan 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants