PR feedback

client/package.json

@@ -91,6 +91,7 @@
     },
     "mocha": {
         "timeout": 72000,
+        "bail": true,
         "require": [
             "source-map-support/register"
         ],

client/src/ECP.ts

@@ -51,14 +51,19 @@ export class ECP {
 		this.device.setConfig(config);
 	}
 
-	/** Provides a way to get the whole config not just this classes' Config */
+	/**
+	 * Get the full RTA config
+	 */
 	public getRtaConfig() {
 		if (!this.config) {
 			this.config = utils.getConfigFromEnvironmentOrConfigFile();
 		}
 		return this.config;
 	}
 
+	/**
+	 * Get the ECP config from the full RTA config.
+	 */
 	public getConfig() {
 		return this.getRtaConfig()?.ECP;
 	}

client/src/NetworkProxy.ts

@@ -20,14 +20,19 @@ export class NetworkProxy {
 		this.config = config;
 	}
 
-	/** Provides a way to get the whole config not just this classes' Config */
+	/**
+	 * Get the full RTA config
+	 */
 	public getRtaConfig() {
 		if (!this.config) {
 			this.config = utils.getConfigFromEnvironmentOrConfigFile();
 		}
 		return this.config;
 	}
 
+	/**
+	 * Get the NetworkProxy config from the full RTA config.
+	 */
 	public getConfig() {
 		return this.getRtaConfig()?.NetworkProxy;
 	}

client/src/OnDeviceComponent.ts

@@ -32,14 +32,19 @@ export class OnDeviceComponent {
 		this.device.setConfig(config);
 	}
 
-	/** Provides a way to get the whole config not just this classes' Config */
+	/**
+	 * Get the full RTA config
+	 */
 	public getRtaConfig() {
 		if (!this.config) {
 			this.config = utils.getConfigFromEnvironmentOrConfigFile();
 		}
 		return this.config;
 	}
 
+	/**
+	 * Get the OnDeviceComponent config from the full RTA config.
+	 */
 	public getConfig() {
 		return this.getRtaConfig()?.OnDeviceComponent;
 	}

client/src/RokuDevice.ts

@@ -30,14 +30,19 @@ export class RokuDevice {
 		this.config = config;
 	}
 
-	/** Provides a way to get the whole config not just this classes' Config */
+	/**
+	 * Get the full RTA config
+	 */
 	public getRtaConfig() {
 		if (!this.config) {
 			this.config = utils.getConfigFromEnvironmentOrConfigFile();
 		}
 		return this.config;
 	}
 
+	/**
+	 * Get the RokuDevice config from the full RTA config.
+	 */
 	public getConfig() {
 		return this.getRtaConfig()?.RokuDevice;
 	}

client/src/utils.ts

@@ -200,7 +200,7 @@ class Utils {
 		return error;
 	}
 
-	public getTestTitlePath(contextOrSuite: Mocha.Context | Mocha.Suite, sterilize = true) {
+	public getTestTitlePath(contextOrSuite: Mocha.Context | Mocha.Suite, sanitize = true) {
 		let ctx: Mocha.Context;
 		if (contextOrSuite.constructor.name === 'Context') {
 			ctx = contextOrSuite as Mocha.Context;
@@ -215,7 +215,7 @@ class Utils {
 		}
 
 		const pathParts = ctx.currentTest?.titlePath();
-		if (sterilize) {
+		if (sanitize) {
 			for (const [index, pathPart] of pathParts.entries()) {
 				pathParts[index] = filenamify(pathPart);
 			}

device/components/RTA_OnDeviceComponentTask.brs

@@ -99,7 +99,7 @@ sub handleSocketEvent(message as Object)
 			end if
 		end if
 	else
-		' We are switching from recursive code to letting us receive another roSocketEvent where we can handle the different parts of the request
+		' We are relying on the fact that we will continue to get a roSocketEvent until the buffer is empty instead of recursive code to handle receiving the data
 		handleClientSocketEvent(messageSocketId)
 	end if
 end sub