Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows CI #58

Merged
merged 6 commits into from
Jun 25, 2024
Merged

Fix Windows CI #58

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d13e7b1
bump up sleep time in testing
andrewwinters5000 Jun 25, 2024
632b925
bump CI to use julia 1.10
andrewwinters5000 Jun 25, 2024
b136cc9
set sleep command back to 2 seconds
andrewwinters5000 Jun 25, 2024
04c36a6
revert to Julia 1.6 for CI. Didn't fix anything
andrewwinters5000 Jun 25, 2024
8469747
try adding calls to the garbage collector
andrewwinters5000 Jun 25, 2024
621228c
add better comment and cleanup unnecessary sleep commands
andrewwinters5000 Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions test/test_visualization.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,11 @@ using CairoMakie
# Create the mesh which contains a plotting update for ISM
@test_nowarn generate_mesh(p_visu, verbose=true)

# Add a delay to ensure that the Windows system has released the file handles
sleep(2.0) # arbitrarily pick 2 seconds
# Explicitly call the garbage collector to remove any temporaries
# before an attempt to delete any files. Helps avoid an error of type
# `IOError: unlink("some_file"): resource busy or locked (EBUSY)`
# on Windows CI runners
GC.gc()

# Destroy the mesh and reset the background grid
@test_nowarn remove_mesh!(p_visu)
Expand Down Expand Up @@ -95,8 +98,11 @@ using CairoMakie
# Create the mesh which contains a plotting update for ISM-V2
@test_nowarn generate_mesh(p_visu)

# Add a delay to ensure that the Windows system has released the file handles
sleep(2.0) # arbitrarily pick 2 seconds
# Explicitly call the garbage collector to remove any temporaries
# before an attempt to delete any files. Helps avoid an error of type
# `IOError: unlink("some_file"): resource busy or locked (EBUSY)`
# on Windows CI runners
GC.gc()

# Destroy the mesh and reset the background grid
@test_nowarn remove_mesh!(p_visu)
Expand Down
Loading