Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cell list management to a new struct #12

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Move cell list management to a new struct #12

merged 7 commits into from
Jun 17, 2024

Conversation

efaulhaber
Copy link
Member

@efaulhaber efaulhaber commented May 12, 2024

No description provided.

@efaulhaber efaulhaber added the enhancement New feature or request label May 12, 2024
Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.16%. Comparing base (989d0c0) to head (8f285b8).

Files Patch % Lines
src/nhs_grid.jl 88.88% 2 Missing ⚠️
src/nhs_trivial.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   85.02%   86.16%   +1.13%     
==========================================
  Files           9       10       +1     
  Lines         207      224      +17     
==========================================
+ Hits          176      193      +17     
  Misses         31       31              
Flag Coverage Δ
unit 86.16% <90.90%> (+1.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efaulhaber efaulhaber marked this pull request as ready for review May 13, 2024 12:56
@efaulhaber efaulhaber requested a review from LasNikas May 13, 2024 12:56
Copy link
Collaborator

@LasNikas LasNikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LasNikas LasNikas merged commit e503620 into main Jun 17, 2024
10 checks passed
@LasNikas LasNikas deleted the ef/cell-list branch June 17, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants