Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use smesh_jll #7

Merged
merged 7 commits into from
Jan 26, 2024
Merged

Use smesh_jll #7

merged 7 commits into from
Jan 26, 2024

Conversation

sloede
Copy link
Member

@sloede sloede commented Jan 26, 2024

Fixes #4

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d4fb34) 100.00% compared to head (613297a) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            7         7           
=========================================
  Hits             7         7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sloede
Copy link
Member Author

sloede commented Jan 26, 2024

Note that 613297a is due to the fact that for Julia v1.9 or older, libgfortran4 is shipped with Julia. However, smesh requires libgfortran5 or later, since it uses Fortran 2018. Therefore, we disable testing on those systems.

Should we have real user demand for macOS support on Intel processors and Julia v1.9 or older, we can revisit the decision to require -std=f2018 in smesh.

@sloede sloede enabled auto-merge January 26, 2024 18:14
@sloede sloede disabled auto-merge January 26, 2024 18:15
@sloede
Copy link
Member Author

sloede commented Jan 26, 2024

I'll go ahead and merge this without approval, such that I can get the registration process started.

@sloede sloede merged commit 0e9ef7e into main Jan 26, 2024
11 checks passed
@sloede sloede deleted the msl/add-jll-dependency branch January 26, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CI once JLL package is available
2 participants