Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend CompressibleEulerQuasi1D and ShallowWaterQuasi1D to DGMulti #1797

Merged
merged 14 commits into from
Jan 4, 2024
Merged

Extend CompressibleEulerQuasi1D and ShallowWaterQuasi1D to DGMulti #1797

merged 14 commits into from
Jan 4, 2024

Commits on Jan 3, 2024

  1. adding DGMulti versions of fluxes

    @jlchan
    jlchan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    5321c8d View commit details
    Browse the repository at this point in the history

  2. remove incorrect factor of 2

    @jlchan
    jlchan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    db89b06 View commit details
    Browse the repository at this point in the history

  3. add example and test

    @jlchan
    jlchan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    5e8545a View commit details
    Browse the repository at this point in the history

  4. formatting

    @jlchan
    jlchan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    3db8680 View commit details
    Browse the repository at this point in the history

  5. add comment

    @jlchan
    jlchan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    2595ac3 View commit details
    Browse the repository at this point in the history

  6. revert removing factor of 2

    @jlchan
    jlchan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    93bff5a View commit details
    Browse the repository at this point in the history

  7. formatting

    @jlchan
    jlchan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    a28a560 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. add SWE quasi-1D test 

    d
    @jlchan
    jlchan committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    ee5d3f2 View commit details
    Browse the repository at this point in the history

  2. enable quasi1D SWE for DGMulti

    @jlchan
    jlchan committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    5fe4faf View commit details
    Browse the repository at this point in the history

  3. add docstrings

    @jlchan
    jlchan committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    3384553 View commit details
    Browse the repository at this point in the history

  4. formatting

    @jlchan
    jlchan committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    a62cca0 View commit details
    Browse the repository at this point in the history

  5. Update src/equations/compressible_euler_quasi_1d.jl 

    Co-authored-by: Hendrik Ranocha <[email protected]>
    @jlchan @ranocha
    jlchan and ranocha authored Jan 4, 2024
    Configuration menu
    Copy the full SHA
    b3cfd96 View commit details
    Browse the repository at this point in the history

  6. adding comments explaining why normal_direction is included in 1D

    @jlchan
    jlchan committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    75e7d27 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: Daniel Doehring <[email protected]>
    @jlchan @DanielDoehring
    jlchan and DanielDoehring authored Jan 4, 2024
    Configuration menu
    Copy the full SHA
    fdb34c4 View commit details
    Browse the repository at this point in the history