-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quad-Based Icosahedral Grid #50
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 87.56% 89.56% +2.00%
==========================================
Files 18 19 +1
Lines 1447 1706 +259
==========================================
+ Hits 1267 1528 +261
+ Misses 180 178 -2 ☔ View full report in Codecov by Sentry. |
#52) * Added the possibility to have multiple trees per quad face of icosahedron * Updated advection elixir (and test) that uses the quad-based icosahedral grid
…s in the initial condition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The failing test is unrelated to these changes, see trixi-framework/Trixi.jl#2185 (comment).
This PR implements a quad-based icosahedral grid of the sphere as a
P4estMesh{2}
. The mesh has60 * trees_per_face_dimension^2
trees: 20 triangular faces of the icosahedron, each subdivided into 3 parent quads, each of which subdivided intotrees_per_face_dimension^2
trees.The following convergence results can be obtained using:
Advection_IcosahedralGrid.mp4