Fix type stability and LMARS structure

[MarcoArtiano]

See Exact floating-point numbers .

This PR also changes the structure of the LMARS flux, by calling the same struct used in Trixi.jl.

[codecov]

Codecov Report

Attention: Patch coverage is 89.58333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.45%. Comparing base (1c05c56) to head (035bad3).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/equations/compressible_moist_euler_2d_lucas.jl	88.88%	3 Missing ⚠️
src/equations/shallow_water_3d.jl	90.47%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   89.45%   89.45%   -0.01%     
==========================================
  Files          20       20              
  Lines        1802     1801       -1     
==========================================
- Hits         1612     1611       -1     
  Misses        190      190              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MarcoArtiano]

Thank you very much, @sloede! I’ll look for the missing ones as soon as I can.

[ranocha]

Just a minor suggestion - otherwise, this looks good to me 👍

[ranocha]

Fine from my side - but the maintainers like @benegee and @tristanmontoya should also have a look at it.

[ranocha]

@MarcoArtiano The format check fails. Could you please run the formatter locally to fix it?

[tristanmontoya]

Fine from my side - but the maintainers like @benegee and @tristanmontoya should also have a look at it.

All looks good to me; I like having the LMARS be consistent with Trixi.jl. Once the format check passes, this can be merged.

[MarcoArtiano]

Fine from my side - but the maintainers like @benegee and @tristanmontoya should also have a look at it.

All looks good to me; I like having the LMARS be consistent with Trixi.jl. Once the format check passes, this can be merged.

Thanks! Now it's ready to be merged.

[tristanmontoya]

LGTM!