Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise docs for custom quantities #423

Closed

Conversation

efaulhaber
Copy link
Member

@efaulhaber efaulhaber commented Mar 5, 2024

Closes #384.

Also check out what I wrote in #424.

@efaulhaber efaulhaber added the documentation Improvements or additions to documentation label Mar 5, 2024
@efaulhaber efaulhaber added this to the 0.1 milestone Mar 5, 2024
Comment on lines +13 to +15
function kinetic_energy(v, u, t, system::BoundarySystem)
return 0.0
end
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved all of these functions without changing anything. I only added this function here and the short docstrings.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 70.84%. Comparing base (53b1484) to head (ffc810e).
Report is 1 commits behind head on main.

Files Patch % Lines
src/general/custom_quantities.jl 0.00% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
- Coverage   70.99%   70.84%   -0.15%     
==========================================
  Files          65       66       +1     
  Lines        3799     3807       +8     
==========================================
  Hits         2697     2697              
- Misses       1102     1110       +8     
Flag Coverage Δ
unit 70.84% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs for custom quantities
2 participants