Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reopen #351: Complex shapes #439

Merged
merged 136 commits into from
Aug 6, 2024

Conversation

LasNikas
Copy link
Collaborator

@LasNikas LasNikas commented Mar 5, 2024

No description provided.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 77.96258% with 106 lines in your changes missing coverage. Please review.

Project coverage is 69.94%. Comparing base (d48e4c5) to head (4ccf4c6).

Files Patch % Lines
...reprocessing/point_in_poly/hierarchical_winding.jl 56.84% 63 Missing ⚠️
src/preprocessing/geometries/triangle_mesh.jl 86.40% 17 Missing ⚠️
src/preprocessing/geometries/polygon.jl 80.00% 12 Missing ⚠️
src/preprocessing/geometries/io.jl 83.72% 7 Missing ⚠️
src/setups/complex_shape.jl 81.81% 4 Missing ⚠️
...rocessing/point_in_poly/winding_number_jacobson.jl 95.83% 2 Missing ⚠️
...eprocessing/point_in_poly/winding_number_horman.jl 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
+ Coverage   69.11%   69.94%   +0.83%     
==========================================
  Files          76       86      +10     
  Lines        4637     5118     +481     
==========================================
+ Hits         3205     3580     +375     
- Misses       1432     1538     +106     
Flag Coverage Δ
unit 69.94% <77.96%> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svchb svchb added this to the 0.2 milestone Mar 6, 2024
@efaulhaber efaulhaber removed this from the 0.2 milestone Mar 10, 2024
@LasNikas LasNikas requested a review from svchb August 1, 2024 14:44
NEWS.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
NEWS.md Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
src/preprocessing/point_in_poly/hierarchical_winding.jl Outdated Show resolved Hide resolved
examples/preprocessing/complex_shape_2d.jl Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
src/setups/complex_shape.jl Outdated Show resolved Hide resolved
test/setups/complex_shape.jl Outdated Show resolved Hide resolved
test/setups/complex_shape.jl Outdated Show resolved Hide resolved
test/setups/complex_shape.jl Outdated Show resolved Hide resolved
test/setups/complex_shape.jl Outdated Show resolved Hide resolved
test/setups/complex_shape.jl Show resolved Hide resolved
test/setups/complex_shape.jl Outdated Show resolved Hide resolved
test/setups/complex_shape.jl Outdated Show resolved Hide resolved
@LasNikas LasNikas enabled auto-merge (squash) August 6, 2024 08:27
@LasNikas LasNikas requested a review from svchb August 6, 2024 08:28
@LasNikas LasNikas merged commit 6828fcf into trixi-framework:main Aug 6, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants