Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system tests (smoke tests for now) #47

Merged
merged 4 commits into from
Jan 11, 2023

Conversation

efaulhaber
Copy link
Member

@efaulhaber efaulhaber commented Jan 9, 2023

See #48.

@efaulhaber efaulhaber added the testing Improvements or additions to tests label Jan 9, 2023
@efaulhaber efaulhaber mentioned this pull request Jan 10, 2023
48 tasks
@efaulhaber efaulhaber marked this pull request as ready for review January 10, 2023 13:30
@efaulhaber efaulhaber requested a review from LasNikas January 10, 2023 13:30
Copy link
Collaborator

@LasNikas LasNikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! That was necessary. Thank you.
Just a few comments

water_density = 1000.0

container_width = 4.0
container_height = 2.0

setup = RectangularTank(fluid_particle_spacing, beta, water_width, water_height,
setup = RectangularTank(fluid_particle_spacing, 3, water_width, water_height,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is wrong with having beta?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually use the boundaries from the setup here, only the water column. This will be replaced with #42 anyway.

src/containers/solid_container.jl Show resolved Hide resolved
test/Project.toml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Improvements or additions to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants