Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.2 #561

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Release v0.2 #561

merged 5 commits into from
Jul 9, 2024

Conversation

efaulhaber
Copy link
Member

@efaulhaber efaulhaber commented Jun 27, 2024 •
edited
Loading

Waiting on breaking changes in trixi-framework/PointNeighbors.jl#42.
Based on #562.

efaulhaber and others added 2 commits June 27, 2024 13:47
@efaulhaber
Use new v0.3 release of PointNeighbors.jl (#550)
2326d03 
* Replace `for_particle_neighbor`

* Change kwarg `particles` to `points`

* Remove `create_neighborhood_search`

* Fix examples and tests

* Reintroduce `create_neighborhood_search` to allow `nothing`

* Restrict PointNeighbors.jl version

* Fix tests

* Fix tests

* Fix examples

* Fix validation

* Fix docs

* Mention periodic boxes in the docs

* Fix tests

* Fix tests
@svchb @efaulhaber
Prepare Release 0.2 (#557)
dbc07c3 
* Prepare Release 0.2

* Set Version Number

* Change wording

* Change formatting

* Review comment

Co-authored-by: Erik Faulhaber <[email protected]>

* Formatting

---------

Co-authored-by: Erik Faulhaber <[email protected]>
@efaulhaber efaulhaber added the breaking changes This change will break the public API and requires a new major release label Jun 27, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.67347% with 8 lines in your changes missing coverage. Please review.

Project coverage is 69.72%. Comparing base (f321e11) to head (964c2e9).

Files Patch % Lines
src/general/corrections.jl 25.00% 3 Missing ⚠️
src/general/semidiscretization.jl 94.44% 1 Missing ⚠️
...chemes/boundary/dummy_particles/dummy_particles.jl 50.00% 1 Missing ⚠️
src/schemes/fluid/surface_tension.jl 0.00% 1 Missing ⚠️
...fluid/weakly_compressible_sph/density_diffusion.jl 0.00% 1 Missing ⚠️
src/schemes/solid/discrete_element_method/rhs.jl 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
- Coverage   69.80%   69.72%   -0.09%     
==========================================
  Files          75       75              
  Lines        4573     4551      -22     
==========================================
- Hits         3192     3173      -19     
+ Misses       1381     1378       -3
Flag Coverage Δ
unit 69.72% <83.67%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efaulhaber efaulhaber changed the title Release 0.2 Release v0.2 Jun 27, 2024
@efaulhaber
Merge branch 'main' into dev
19a64ec
@efaulhaber
Use new v0.4 release of PointNeighbors.jl (#562)
5e4ccb4 
* Use PointNeighbors v0.4

* Apply new changes

* Fix docs

* Update validation files

The new version of PointNeighbors.jl changed the particles ordering in the neighborhood search.

* Why did this file change again?

* Update WCSPH validation files due to viscosity reformulation

* Update validation files on a single thread

* Increase tolerances for Julia 1.9
@efaulhaber
Use @threaded macro from PointNeighbors.jl (#573)
964c2e9 
* Use `@threaded` from PointNeighbors.jl

* Remove `adapt_structure` definitions that are also in PointNeighbors.jl

* Use PointNeighbors.jl v0.4.1

* Use v0.4.2 of PointNeighbors.jl
@efaulhaber efaulhaber marked this pull request as ready for review July 9, 2024 09:28
@efaulhaber efaulhaber enabled auto-merge July 9, 2024 09:29
LasNikas
LasNikas reviewed Jul 9, 2024
View reviewed changes
src/general/semidiscretization.jl
Comment on lines +280 to +281
# Initialize this system
initialize!(system, neighborhood_search)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused why we pass neighborood_search here.
This is a system initialization and the only initialized system here is the tlsph system.
The nhs is initialized above, so can we change this to initialize!(system)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or better initialize!(system, semi)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a neighborhood search to initialize the TLSPH system (compute correction matrix and stuff).
And passing the neighborhood search is more convenient than passing the semidiscretization when writing benchmarks in PointNeighbors.jl, where we don't necessarily have a semidiscretization.

@efaulhaber efaulhaber disabled auto-merge July 9, 2024 12:19
@efaulhaber efaulhaber merged commit 166ed4e into main Jul 9, 2024
9 of 10 checks passed
@efaulhaber efaulhaber deleted the dev branch July 9, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LasNikas LasNikas LasNikas left review comments

@svchb svchb svchb approved these changes

Assignees
No one assigned
Labels
breaking changes This change will break the public API and requires a new major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efaulhaber @svchb @LasNikas