Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline viscosity #578

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Inline viscosity #578

merged 2 commits into from
Jul 19, 2024

Conversation

efaulhaber
Copy link
Member

@efaulhaber efaulhaber commented Jul 19, 2024

Okay, hear me out. This is a 1.4-1.5x speedup in the fluid-fluid interact, just by inlining dv_viscosity. Don't ask me why the difference is so extreme.
grafik

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@b3219cb). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files Patch % Lines
src/schemes/fluid/viscosity.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #578   +/-   ##
=======================================
  Coverage        ?   69.73%           
=======================================
  Files           ?       76           
  Lines           ?     4573           
  Branches        ?        0           
=======================================
  Hits            ?     3189           
  Misses          ?     1384           
  Partials        ?        0           
Flag Coverage Δ
unit 69.73% <66.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svchb svchb enabled auto-merge (squash) July 19, 2024 19:48
@svchb svchb merged commit c2670cc into trixi-framework:main Jul 19, 2024
9 of 10 checks passed
@efaulhaber efaulhaber deleted the inline-viscosity branch July 22, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants