Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for DiffEqCallbacks to 4, (keep existing compat) #622

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the DiffEqCallbacks package from 2.25, 3 to 2.25, 3, 4.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@sloede sloede force-pushed the compathelper/new_version/2024-09-28-00-28-06-426-03173249596 branch from 3500197 to 28589ca Compare September 28, 2024 00:28
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.37%. Comparing base (eb9f41b) to head (62be165).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #622   +/-   ##
=======================================
  Coverage   69.37%   69.37%           
=======================================
  Files          85       85           
  Lines        5124     5124           
=======================================
  Hits         3555     3555           
  Misses       1569     1569           
Flag Coverage Δ
unit 69.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sloede
sloede previously approved these changes Sep 28, 2024
@sloede
Copy link
Member

sloede commented Sep 28, 2024

The tests pass, but they still seem to be using DiffEqCallbacks v3.8.0.

@svchb
Copy link
Collaborator

svchb commented Sep 30, 2024

I did run the tests again still 3.8.0.

@svchb
Copy link
Collaborator

svchb commented Oct 10, 2024

Still not being used even with 1.11

@svchb
Copy link
Collaborator

svchb commented Oct 22, 2024

Done in #632

@svchb svchb closed this Oct 22, 2024
@efaulhaber efaulhaber deleted the compathelper/new_version/2024-09-28-00-28-06-426-03173249596 branch October 22, 2024 12:14
@efaulhaber
Copy link
Member

We should keep in mind that the tests are still using 3 instead of 4.

@svchb
Copy link
Collaborator

svchb commented Oct 22, 2024

I checked we are not using any of the changed features at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants