Switch default for foreach_point_neighbor #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les.jlOpen into change_defaults_of_nhs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
==========================================
- Coverage 68.75% 68.71% -0.04%
==========================================
Files 93 93
Lines 5840 5840
==========================================
- Hits 4015 4013 -2
- Misses 1825 1827 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
efaulhaber
requested changes
Dec 23, 2024
| @@ -11,7 +11,11 @@ function interact!(dv, v_particle_system, u_particle_system, | |||
| # Loop over all pairs of particles and neighbors within the kernel cutoff. | |||
| foreach_point_neighbor(particle_system, neighbor_system, | |||
| system_coords, neighbor_coords, | |||
| neighborhood_search) do particle, neighbor, pos_diff, distance | |||
| neighborhood_search; | |||
| points=each_moving_particle(particle_system)) do particle, | |||
There was a problem hiding this comment.
Redundant. All particles are moving.
There was a problem hiding this comment.
could be not the case I think if they are deactivated?
| neighborhood_search) do particle, neighbor, | ||
| pos_diff, distance | ||
| neighborhood_search; | ||
| points=each_moving_particle(system)) do particle, neighbor, |
| @@ -103,7 +103,9 @@ function calc_normal_akinci!(system, neighbor_system::FluidSystem, | |||
|
|
|||
| foreach_point_neighbor(system, neighbor_system, | |||
| system_coords, neighbor_system_coords, | |||
| neighborhood_search) do particle, neighbor, pos_diff, distance | |||
| neighborhood_search; | |||
| points=each_moving_particle(system)) do particle, neighbor, | |||
There was a problem hiding this comment.
Is this correct? What about fixed boundary particles?
There was a problem hiding this comment.
It depends but in this model it is assumed that the boundary particles don't belong to the same species.
| @@ -176,7 +176,9 @@ function update!(density_diffusion::DensityDiffusionAntuono, neighborhood_search | |||
| set_zero!(normalized_density_gradient) | |||
|
|
|||
| foreach_point_neighbor(system, system, system_coords, system_coords, | |||
| neighborhood_search) do particle, neighbor, pos_diff, distance | |||
| neighborhood_search; | |||
| points=each_moving_particle(system)) do particle, neighbor, | |||
| @@ -22,7 +22,11 @@ function interact!(dv, v_particle_system, u_particle_system, | |||
| # Loop over all pairs of particles and neighbors within the kernel cutoff. | |||
| foreach_point_neighbor(particle_system, neighbor_system, | |||
| system_coords, neighbor_system_coords, | |||
| neighborhood_search) do particle, neighbor, pos_diff, distance | |||
| neighborhood_search; | |||
| points=each_moving_particle(particle_system)) do particle, | |||
…les.jlOpen into change_defaults_of_nhs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using each_moving_particle as default leads to hard to debug issues especially in multi system simulations.