Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use faraday's url generator so we know the code we test is the code we run #8

Merged
merged 2 commits into from
Jul 5, 2020

Conversation

trobrock
Copy link
Owner

No description provided.

@trobrock
Copy link
Owner Author

@aselder this should fix the issues from #7

@aselder
Copy link

aselder commented Mar 20, 2014

That should work other than the fact that Outright can't use Faraday 0.9 due to restrictions on the oauth2 and slack-notify gems. I'll work around it.

@trobrock
Copy link
Owner Author

Nope thats not all we need.... Hold on.

@trobrock
Copy link
Owner Author

So I am now passing args to the build_url that work, but they still seem to break when they go into the get method

@aselder
Copy link

aselder commented Mar 21, 2014

If we get it working, I can get the app to use Faraday 0.9.0

@trobrock
Copy link
Owner Author

I'll look into this more tomorrow, I'll have to dig in to see where else the url would be messed with.

@aselder
Copy link

aselder commented Mar 21, 2014

Thanks, let me know if I can help.

On 20 Mar 2014, at 17:03, Trae Robrock wrote:

I'll look into this more tomorrow, I'll have to dig in to see where
else the url would be messed with.


Reply to this email directly or view it on GitHub:
#8 (comment)

@trobrock trobrock merged commit 5955b17 into master Jul 5, 2020
@trobrock trobrock deleted the fix-multi-target branch July 5, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants