Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(protobuf): change transaction data structure description #5602

Merged

Conversation

forfreeday
Copy link
Contributor

@forfreeday forfreeday commented Nov 27, 2023

What does this PR do?
change document description.

Why are these changes required?

change incorrect description of raw for Transaction in Tron protobuf protocol document.md documentation.
This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@@ -546,9 +546,9 @@ Transaction and transaction-related messages.

message `raw`

`ref_block_bytes`: Deprecated.
`ref_block_bytes`: now block bytes in transaction head.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setRefBlockBytes(ByteString.copyFrom(ByteArray.subArray(refBlockNum, 6, 8)))


`ref_block_num`: now block number in transaction head.
`ref_block_num`: Deprecated.

`ref_block_hash`: now block hash in transaction head.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setRefBlockHash(ByteString.copyFrom(ByteArray.subArray(blockHash, 8, 16)))

1. modify `ref_block_bytes` Description
2. modify `ref_block_hash` Description
@forfreeday forfreeday changed the title docs(protobuf): fix transaction data structure description docs(protobuf): change transaction data structure description Dec 8, 2023
@halibobo1205 halibobo1205 merged commit 3f3ffe9 into tronprotocol:develop Dec 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants