Skip to content

Commit

Permalink
Merge pull request #849 from truefoundry/md_add_nodepool_selector_for…
Browse files Browse the repository at this point in the history 
…_buildkit

Added node selector for amd in buildkit service helm chart
  • Loading branch information
@mitanshudodia
mitanshudodia authored Dec 6, 2024
2 parents b47415c + ab385d2 commit b71edb6
Show file tree
Hide file tree
Showing 4 changed files with 49 additions and 5 deletions.
2 changes: 1 addition & 1 deletion charts/tfy-buildkitd-service/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: tfy-buildkitd-service
description: Buildkitd service chart
type: application
version: 0.2.2
version: 0.2.3-rc.1
appVersion: "0.17.0"
maintainers:
- name: truefoundry
39 changes: 38 additions & 1 deletion charts/tfy-buildkitd-service/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,44 @@ Tfy-buildkitd-service is a Helm chart provided by TrueFoundry that facilitates t

## Parameters

############ Parameters for tfyBuildkitdService
############# Parameters for tfyBuildkitdService

| Name | Description | Value |
| -------------------------------------- | ----------------------------------------------------------------------------------------------------------------- | --------------------------- |
| `replicaCount` | Number of replicas of Value kept for future use, kept 1 | `1` |
| `image.repository` | tfyBuildkitdService repository | `moby/buildkit` |
| `image.pullPolicy` | Pull policy for tfyBuildkitdService | `IfNotPresent` |
| `image.tag` | Image tag whose default is the chart appVersion. | `v0.17.0` |
| `storage.enabled` | Bool to enable storage for tfyBuildkitdService | `true` |
| `storage.accessModes` | Access mode for tfyBuildkitdService | `["ReadWriteOnce"]` |
| `storage.storageClassName` | Storage class name for tfyBuildkitdService | `""` |
| `storage.size` | Size of the storage for tfyBuildkitdService | `200Gi` |
| `imagePullSecrets` | Secrets to pull images | `[]` |
| `nameOverride` | String to override partial name passed in helm install command | `""` |
| `fullnameOverride` | String to override full name passed in helm install command | `""` |
| `serviceAccount.create` | Bool to enable serviceAccount creation | `true` |
| `serviceAccount.annotations` | Annotations to add to the serviceAccount | `{}` |
| `serviceAccount.name` | Name of the serviceAccount to use. If not set and create is true, a name is generated using the fullname template | `""` |
| `podAnnotations` | Annotations to be added to the pod | `{}` |
| `podSecurityContext` | Security context for the pod | `{}` |
| `securityContext.privileged` | Security Context for the tfyBuildkitdServiceProxy container | `true` |
| `service.type` | Type for tfyBuildkitdService Service | `ClusterIP` |
| `service.port` | Port for tfyBuildkitdService service | `1234` |
| `resources.limits.cpu` | CPU resource limits for tfyBuildkitdService container. | `2500m` |
| `resources.limits.memory` | Memory Resource limits for tfyBuildkitdService container. | `8Gi` |
| `resources.limits.ephemeral-storage` | Ephemeral Storage limits for tfyBuildkitdService container. | `100Mi` |
| `resources.requests.cpu` | CPU resource requests for tfyBuildkitdService container. | `2500m` |
| `resources.requests.memory` | Memory Resource requests for tfyBuildkitdService container. | `8Gi` |
| `resources.requests.ephemeral-storage` | Ephemeral Storage requests for tfyBuildkitdService container. | `100Mi` |
| `extraVolumes` | List of Volumes to attach to tfyBuildkitdService container | `[]` |
| `extraVolumeMounts` | List of Volume Mounts to attach to tfyBuildkitdService container | `[]` |
| `extraEnvs` | List of Environment Variables to attach to tfyBuildkitdService container | `[]` |
| `nodeSelector` | Parameters to select for scheduling of pod on a node | `{}` |
| `tolerations` | Taints that pod can tolerate | `[]` |
| `affinity` | Affinity rules for pod scheduling on a node | `{}` |
| `tls.buildkitDaemonCertsSecretName` | Name of secret containing the buildkit daemon certs | `tfy-buildkit-daemon-certs` |
| `tls.buildkitClientCertsSecretName` | Name of secret containing the buildkit client certs | `tfy-buildkit-client-certs` |
| `tls.enabled` | Enable TLS for buildkitd | `false` |

| Name | Description | Value |
| -------------------------------------- | ----------------------------------------------------------------------------------------------------------------- | --------------------------- |
Expand Down
9 changes: 9 additions & 0 deletions charts/tfy-buildkitd-service/templates/_helpers.tpl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,12 @@ Create the name of the service account to use
{{- default "default" .Values.serviceAccount.name }}
{{- end }}
{{- end }}

{{/*
Merge nodeSelector
*/}}
{{- define "buildkitd-service.nodeSelector" -}}
{{- $defaultNodeSelector := dict "kubernetes.io/arch" "amd64" }}
{{- $mergedNodeSelector := merge .Values.nodeSelector $defaultNodeSelector }}
{{- toYaml $mergedNodeSelector }}
{{- end }}
4 changes: 1 addition & 3 deletions charts/tfy-buildkitd-service/templates/statefulset.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,8 @@ spec:
{{- with .Values.extraVolumes }}
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with .Values.nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- include "buildkitd-service.nodeSelector" . | nindent 8 }}
{{- with .Values.affinity }}
affinity:
{{- toYaml . | nindent 8 }}
Expand Down

0 comments on commit b71edb6

Please sign in to comment.