Skip to content

Commit

Permalink
Merge pull request #13 from truefoundry/karpenter-fargate-disabled
Browse files Browse the repository at this point in the history
disabled fargate support for karpenter because of loki
  • Loading branch information
shubhamrai1993 authored Jul 18, 2024
2 parents c1f5db3 + 22a1db8 commit 28f9631
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ No resources.
| <a name="input_initial_node_pool_min_size"></a> [initial\_node\_pool\_min\_size](#input\_initial\_node\_pool\_min\_size) | Minimum size for the initial node pool | `number` | `2` | no |
| <a name="input_karpenter_fargate_profile_attach_cni_policy"></a> [karpenter\_fargate\_profile\_attach\_cni\_policy](#input\_karpenter\_fargate\_profile\_attach\_cni\_policy) | Attach CNI policy to IAM role for Karpenter Fargate profile | `bool` | `true` | no |
| <a name="input_karpenter_fargate_profile_create_iam_role"></a> [karpenter\_fargate\_profile\_create\_iam\_role](#input\_karpenter\_fargate\_profile\_create\_iam\_role) | Create IAM role for Karpenter Fargate profile | `bool` | `true` | no |
| <a name="input_karpenter_fargate_profile_enabled"></a> [karpenter\_fargate\_profile\_enabled](#input\_karpenter\_fargate\_profile\_enabled) | Enable Karpenter Fargate profile | `bool` | `true` | no |
| <a name="input_karpenter_fargate_profile_enabled"></a> [karpenter\_fargate\_profile\_enabled](#input\_karpenter\_fargate\_profile\_enabled) | Enable Karpenter Fargate profile | `bool` | `false` | no |
| <a name="input_karpenter_fargate_profile_namespace"></a> [karpenter\_fargate\_profile\_namespace](#input\_karpenter\_fargate\_profile\_namespace) | value of the namespace where Karpenter is installed | `string` | `"karpenter"` | no |
| <a name="input_node_security_group_additional_rules"></a> [node\_security\_group\_additional\_rules](#input\_node\_security\_group\_additional\_rules) | List of additional security group rules to add to the node security group created. Set `source_cluster_security_group = true` inside rules to set the `cluster_security_group` as source | `any` | `{}` | no |
| <a name="input_node_security_group_tags"></a> [node\_security\_group\_tags](#input\_node\_security\_group\_tags) | List of node security group tags | `any` | `{}` | no |
Expand Down
3 changes: 2 additions & 1 deletion upgrade-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@ This guide will help you to migrate your terraform code across versions. Keeping
2. Ensure that you runnning on the EKS version `1.30` which is the default version in `0.5.2`

## Upgrade changes (manual)
1. Execute the terraform apply with version `0.6.0`. If it fails run the below command to import access entry for cluster creator
1. Execute the terraform apply with version `0.6.1`. If it fails run the below command to import access entry for cluster creator
```
terragrunt import 'module.aws-eks-kubernetes-cluster.aws_eks_access_entry.this["cluster_creator"]' "$IAM_PRINCIPAL_ARN"
terragrunt import 'module.aws-eks-kubernetes-cluster.aws_eks_access_policy_association.this["cluster_creator_admin"]' $CLUSTER_NAME#$IAM_PRINCIPAL_ARN#arn:aws:eks::aws:cluster-access-policy/AmazonEKSClusterAdminPolicy
```
2. If you still face any issue, go ahead and delete the access entry created in the EKS console Access tab and then run `terraform apply`
2 changes: 1 addition & 1 deletion variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ variable "tags" {
variable "karpenter_fargate_profile_enabled" {
description = "Enable Karpenter Fargate profile"
type = bool
default = true
default = false
}

variable "karpenter_fargate_profile_namespace" {
Expand Down

0 comments on commit 28f9631

Please sign in to comment.