Merge pull request #56 from truenas/unit-tests-for-apps-validation

NAS-131615 / 25.04 / Add unit tests for apps validation

.github/workflows/tests.yml

@@ -0,0 +1,28 @@
+name: Unit Tests
+
+on: [push]
+
+jobs:
+  run-unit-test:
+    name: Run Unit Tests
+    runs-on: ubuntu-latest
+    container:
+      image: ghcr.io/truenas/middleware:master
+
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@v3
+
+      - name: Install dev-tools
+        run: |
+          install-dev-tools
+
+      - name: Install dependencies
+        run: |
+          apt install python3-pytest-mock -y
+
+      - name: Run Tests
+        run: |
+          PYTHONPATH=$(pwd) pytest apps_validation/pytest/unit/
+          PYTHONPATH=$(pwd) pytest catalog_reader/pytest/unit/
+          PYTHONPATH=$(pwd) pytest apps_schema/pytest/unit/

.gitignore

@@ -11,3 +11,5 @@ catalog_reader/__pycache__/*
 catalog_reader/*/__pycache__/*
 catalog_templating/__pycache__/*
 catalog_templating/*/__pycache__/*
+__pycache__
+.coverage

apps_validation/pytest/unit/test_attr_schema.py → apps_schema/pytest/unit/test_attr_schema.py

@@ -499,12 +499,56 @@
         },
         False
     ),
+    (
+        'attribute',
+        False
+    ),
+    (
+        {
+            'type': 'string',
+            '$ref': [123]
+        },
+        False
+    ),
+    (
+        {
+            'type': 'text',
+        },
+        True
+    ),
+    (
+        {
+            'type': 'string',
+            'default': 'test',
+            'enum': [{
+                'value': 'test',
+                'description': 'test'
+            }]
+        },
+        True
+    ),
+    (
+        {
+            'type': 'string',
+            'default': 'invalid',
+            'enum': [{
+                'value': 'test',
+                'description': 'test'
+            }]
+        },
+        False
+    ),
 ])
 def test_schema_validation(schema, should_work):
+    schema_object = get_schema(schema)
     if not should_work:
-        with pytest.raises(ValidationErrors):
-            get_schema(schema).validate('')
+        if schema_object is None:
+            assert schema_object is None
+        else:
+            with pytest.raises(ValidationErrors):
+                schema_object.validate('')
     else:
-        assert get_schema(schema).validate('') is None
+        assert schema_object.validate('', schema) is None
+        assert schema_object.get_schema_str(schema) == str(schema)+"."
 
 # FIXME: Port validate_question test as well