Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD-1617 / 25.04 / Pd 1617 create asigra tutoral update solutions article #3370

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

micjohnson777
Copy link
Contributor

This PR creates a new Asigra DS-System app tutorial.

Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.

This commit updates the rest of the Asigra tutorial content and adds more screenshots.
More updates expected after we acquire the Asigra account credentials to test and validate the rest of the app deployment.
@micjohnson777 micjohnson777 requested a review from a team as a code owner December 13, 2024 18:44
@micjohnson777 micjohnson777 marked this pull request as draft December 13, 2024 18:44
@bugclerk bugclerk changed the title Pd 1617 create asigra tutoral update solutions article PD-1617 / 25.04 / Pd 1617 create asigra tutoral update solutions article Dec 13, 2024
@bugclerk
Copy link
Contributor

This commit adds more content and new screenshots to the tutorial.
@micjohnson777 micjohnson777 marked this pull request as ready for review December 17, 2024 17:08
This commit pushes updates to the InstallWizardEnvironVariableSettings.md snippet to make it more generic.

It also makes a few content corrections to the tutorial.
This commit removes the GPU references, and changes line62 to make the text less awkwardly worded.
@linzi-ix linzi-ix added the Technical Writer Review (LM) A technical writer is reviewing the PR. label Dec 18, 2024
Copy link
Contributor

@linzi-ix linzi-ix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor comments

content/TruenasApps/EnterpriseApps/AsigraApp.md Outdated Show resolved Hide resolved
content/TruenasApps/EnterpriseApps/AsigraApp.md Outdated Show resolved Hide resolved
micjohnson777 and others added 2 commits December 20, 2024 13:57
Corrected line 127, kept either and combined with line 128 that had the other option.
@micjohnson777
Copy link
Contributor Author

Just waiting on Stavros' review before appove/merge.

Copy link
Contributor

@stavros-k stavros-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only need to remove the gpu reference

This commit changes the screenshot and Resources Configuration section by removing GPU content
@micjohnson777
Copy link
Contributor Author

GPU content removed, Resources Configuration image changed to remove the GPU setting. Ready to merge now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Re-Review Technical Writer Review (LM) A technical writer is reviewing the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants