New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-133683 / 25.04-RC.1 / Refactor CPU reporting (by Qubad786) #15493

Open

bugclerk wants to merge 1 commit into stable/fangtooth from NAS-133683-25.04-RC.1

Contributor

bugclerk commented Jan 27, 2025

Context

It was requested that we make some refactoring changes to our CPU reporting. Following points have been catered to:

/proc/stat has been disabled
CPU stats like user/nice etc are not being saved/retrieved
We were calculating the usage incorrectly which has been addressed
Data structure of CPU stats has been changed in realtime reporting

Example payload of what we send in realtime reporting for CPU metrics

    "cpu": {
      "cpu": {
        "usage": 33,
        "temp": null
      },
      "cpu0": {
        "usage": 100,
        "temp": null
      },
      "cpu1": {
        "usage": 1,
        "temp": null
      },
      "cpu2": {
        "usage": 0,
        "temp": null
      }
    },

Original PR: #15445
Jira URL: https://ixsystems.atlassian.net/browse/NAS-133683


          Refactor CPU reporting

75d6c4e

(cherry picked from commit 9479e43)

bugclerk assigned Qubad786

yocalebo requested a review from Qubad786

January 27, 2025 12:52

Qubad786 approved these changes

View reviewed changes

yocalebo added the DO NOT MERGE label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels