Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133757 / 25.10 / Prevent crashes when pwenc_secret is missing #15498

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

themylogin
Copy link
Contributor

When pwenc_secret is missing, complex data structures are replaced with empty arrays/dictionaries, resulting in various crashes. The only remedy is to wipe out the affected tables entirely.

@bugclerk bugclerk changed the title Prevent crashes when pwenc_secret is missing NAS-133757 / 25.10 / Prevent crashes when pwenc_secret is missing Jan 28, 2025
@bugclerk
Copy link
Contributor

@themylogin
Copy link
Contributor Author

Note: the user uploaded the full database config that included the correct pwenc_secret. Howerer, it was not respected during migrations due to https://ixsystems.atlassian.net/browse/NAS-133381 so VM devices table was always damaged. Having invalid VM devices prevented nginx config from being generated.

@themylogin themylogin requested a review from a team January 28, 2025 13:02
@themylogin
Copy link
Contributor Author

time 4:00

@themylogin themylogin merged commit b4f96f9 into master Feb 3, 2025
2 checks passed
@themylogin themylogin deleted the NAS-133757 branch February 3, 2025 11:01
@bugclerk
Copy link
Contributor

bugclerk commented Feb 3, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants