NAS-133206 / 25.10 / Convert boot.* to versioned API

[creatorcary]

http://jenkins.eng.ixsystems.net:8080/job/tests/job/api_tests/2843/

#15462

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-133206

[themylogin]

@yocalebo I see a little bit of roles chaos here. How are they assigned? Should they be assigned here at all?

[creatorcary]

I see a little bit of roles chaos here. How are they assigned? Should they be assigned here at all?

As of #15347, endpoints that require auth must list roles. I do think that with this change we should better document our roles, maybe give each one a docstring describing specifically what each one is to be used for in role.py (The difference between read/write roles is self explanatory).

[anodos325]

Removing roles from private endpoints goes beyond scope of this PR.

[creatorcary]

Removing roles from private endpoints goes beyond scope of this PR.

@anodos325 You're right, I've made a ticket to address this later https://ixsystems.atlassian.net/browse/NAS-133901. The refactor I'd like to make if it has enough support is to condense the roles, private, authorization_required and authentication_required kwargs into a single required keyword arg access with the following (exclusive) options from most to least restrictive:

• "PRIVATE"
• list of roles
• "NO_AUTHZ_REQUIRED"
• "NO_AUTH_REQUIRED"

which would eliminate all the messy and unclear relationships between our current kwargs.

[anodos325]

Removing roles from private endpoints goes beyond scope of this PR.

@anodos325 You're right, I've made a ticket to address this later https://ixsystems.atlassian.net/browse/NAS-133901. The refactor I'd like to make if it has enough support is to condense the roles, private, authorization_required and authentication_required kwargs into a single required keyword arg access with the following (exclusive) options from most to least restrictive:

* "PRIVATE"

* list of roles

* "NO_AUTHZ_REQUIRED"

* "NO_AUTH_REQUIRED"

which would eliminate all the messy and unclear relationships between our current kwargs.

Okay. You'll need to approach that very carefully as changes can have subtle security implications.

[creatorcary]

Okay. You'll need to approach that very carefully as changes can have subtle security implications.

Will definitely request your review on it